Replace layout constants in chrome/browser/ui/views/infobars.

Replace layout constants in chrome/browser/ui/views/infobars.

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897
Review-Url: https://codereview.chromium.org/2812243007
Cr-Commit-Position: refs/heads/master@{#464779}
Committed: https://chromium.googlesource.com/chromium/src/+/82438b804d2a93c7ba02ba543ac278eb7142473c

[ananta, 2017-04-14 02:28:56]

ananta@chromium.org changed reviewers:
+ pkasting@chromium.org

[ananta, 2017-04-14 02:29:20]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 02:29:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 02:40:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 02:40:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ananta, 2017-04-14 02:46:01]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 02:46:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 03:50:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 03:50:35]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2017-04-14 07:42:33]

LGTM

https://codereview.chromium.org/2812243007/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/infobars/confirm_infobar.cc (right):

https://codereview.chromium.org/2812243007/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/infobars/confirm_infobar.cc:61:
ChromeLayoutProvider::Get()->GetDistanceMetric(
Nit: Pull layout provider out to a temp for reuse (all places in both files
where we use it multiple times in one function)

https://codereview.chromium.org/2812243007/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/infobars/confirm_infobar.cc:153: int
related_label_horizontal_spacing =
Nit: Try for a shorter name if it's still readable, e.g. |label_spacing|.  These
could also optionally be const.  (all places in both files)

https://codereview.chromium.org/2812243007/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/infobars/infobar_view.cc (right):

https://codereview.chromium.org/2812243007/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/infobars/infobar_view.cc:216: :
related_control_horizontal_spacing);
Nit: Simpler:

  const int padding = ChromeLayoutProvider::Get()->GetDistanceMetric(
                          views::DISTANCE_RELATED_CONTROL_HORIZONTAL);
  return std::min((icon_ ? icon_->bounds().right() : 0) + padding, EndX());

[ananta, 2017-04-14 18:32:33]

https://codereview.chromium.org/2812243007/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/infobars/confirm_infobar.cc (right):

https://codereview.chromium.org/2812243007/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/infobars/confirm_infobar.cc:61:
ChromeLayoutProvider::Get()->GetDistanceMetric(
On 2017/04/14 07:42:32, Peter Kasting wrote:
> Nit: Pull layout provider out to a temp for reuse (all places in both files
> where we use it multiple times in one function)

Done.

https://codereview.chromium.org/2812243007/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/infobars/confirm_infobar.cc:153: int
related_label_horizontal_spacing =
On 2017/04/14 07:42:32, Peter Kasting wrote:
> Nit: Try for a shorter name if it's still readable, e.g. |label_spacing|. 
These
> could also optionally be const.  (all places in both files)

Done.

https://codereview.chromium.org/2812243007/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/infobars/infobar_view.cc (right):

https://codereview.chromium.org/2812243007/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/infobars/infobar_view.cc:216: :
related_control_horizontal_spacing);
On 2017/04/14 07:42:32, Peter Kasting wrote:
> Nit: Simpler:
> 
>   const int padding = ChromeLayoutProvider::Get()->GetDistanceMetric(
>                           views::DISTANCE_RELATED_CONTROL_HORIZONTAL);
>   return std::min((icon_ ? icon_->bounds().right() : 0) + padding, EndX());

Done.

[ananta, 2017-04-14 19:02:24]

The CQ bit was checked by ananta@chromium.org

[ananta, 2017-04-14 19:02:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2812243007/#ps60001
(title: "Address review comments")

[commit-bot: I haz the power, 2017-04-14 19:02:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 19:51:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492196544448670,
"parent_rev": "82cef81d96179a73c2cbdc284140e699c3f125f3", "commit_rev":
"82438b804d2a93c7ba02ba543ac278eb7142473c"}

[commit-bot: I haz the power, 2017-04-14 19:51:53]

Description was changed from

==========
Replace layout constants in chrome/browser/ui/views/infobars.

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897
==========

to

==========
Replace layout constants in chrome/browser/ui/views/infobars.

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897

Review-Url: https://codereview.chromium.org/2812243007
Cr-Commit-Position: refs/heads/master@{#464779}
Committed:
https://chromium.googlesource.com/chromium/src/+/82438b804d2a93c7ba02ba543ac2...
==========

[commit-bot: I haz the power, 2017-04-14 19:51:54]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/82438b804d2a93c7ba02ba543ac2...