Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2812233003: MD Settings Sync: Remove secondary text from 'Manage Synced Data' link (Closed)

Created:
3 years, 8 months ago by tommycli
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings Sync: Remove secondary text from 'Manage Synced Data' link BUG=681226 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2812233003 Cr-Commit-Position: refs/heads/master@{#464146} Committed: https://chromium.googlesource.com/chromium/src/+/e0c1afa12d5cc615038e3a88c65047814607bb99

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/resources/settings/people_page/sync_page.html View 1 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
tommycli
dbeam: PTAL tiny review
3 years, 8 months ago (2017-04-12 19:22:18 UTC) #6
tommycli
dbeam: PTAL tiny review
3 years, 8 months ago (2017-04-12 19:22:19 UTC) #7
Dan Beam
lgtm w/removal https://codereview.chromium.org/2812233003/diff/1/chrome/browser/resources/settings/people_page/sync_page.html File chrome/browser/resources/settings/people_page/sync_page.html (right): https://codereview.chromium.org/2812233003/diff/1/chrome/browser/resources/settings/people_page/sync_page.html#newcode271 chrome/browser/resources/settings/people_page/sync_page.html:271: aria-describedby="manageSyncedDataSecondary"></button> please remove aria-describedby
3 years, 8 months ago (2017-04-12 19:24:22 UTC) #8
tommycli
thanks! https://codereview.chromium.org/2812233003/diff/1/chrome/browser/resources/settings/people_page/sync_page.html File chrome/browser/resources/settings/people_page/sync_page.html (right): https://codereview.chromium.org/2812233003/diff/1/chrome/browser/resources/settings/people_page/sync_page.html#newcode271 chrome/browser/resources/settings/people_page/sync_page.html:271: aria-describedby="manageSyncedDataSecondary"></button> On 2017/04/12 19:24:22, Dan Beam wrote: > ...
3 years, 8 months ago (2017-04-12 19:27:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812233003/20001
3 years, 8 months ago (2017-04-12 19:28:53 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 20:54:04 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e0c1afa12d5cc615038e3a88c650...

Powered by Google App Engine
This is Rietveld 408576698