Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2812123002: Replace shess@ as the owner of SQLite things. (Closed)

Created:
3 years, 8 months ago by pwnall
Modified:
3 years, 8 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace shess@ as the owner of SQLite things. BUG= Review-Url: https://codereview.chromium.org/2812123002 Cr-Commit-Position: refs/heads/master@{#463936} Committed: https://chromium.googlesource.com/chromium/src/+/e28a080e6be1b875a471b23f4ce9a6d11664bb89

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed michaeln feedback. #

Patch Set 3 : Addressed shess feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M components/test/data/web_database/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M components/webdata/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M components/webdata_services/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M sql/OWNERS View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/sqlite/OWNERS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 28 (16 generated)
pwnall
PTAL?
3 years, 8 months ago (2017-04-11 21:58:26 UTC) #4
michaeln
https://codereview.chromium.org/2812123002/diff/1/sql/OWNERS File sql/OWNERS (right): https://codereview.chromium.org/2812123002/diff/1/sql/OWNERS#newcode1 sql/OWNERS:1: pwnall@chromium.org you can add me here too, i'm familiar ...
3 years, 8 months ago (2017-04-11 22:16:16 UTC) #6
pwnall
https://codereview.chromium.org/2812123002/diff/1/sql/OWNERS File sql/OWNERS (right): https://codereview.chromium.org/2812123002/diff/1/sql/OWNERS#newcode1 sql/OWNERS:1: pwnall@chromium.org On 2017/04/11 22:16:16, michaeln wrote: > you can ...
3 years, 8 months ago (2017-04-11 22:25:11 UTC) #9
Scott Hess - ex-Googler
Greg, do you want out of sql/OWNERS at this time?
3 years, 8 months ago (2017-04-11 23:27:59 UTC) #11
Scott Hess - ex-Googler
On 2017/04/11 23:27:59, Scott Hess wrote: > Greg, do you want out of sql/OWNERS at ...
3 years, 8 months ago (2017-04-12 01:50:35 UTC) #14
pwnall
On 2017/04/12 01:50:35, Scott Hess wrote: > On 2017/04/11 23:27:59, Scott Hess wrote: > > ...
3 years, 8 months ago (2017-04-12 02:01:19 UTC) #16
Scott Hess - ex-Googler
On 2017/04/12 02:01:19, pwnall wrote: > On 2017/04/12 01:50:35, Scott Hess wrote: > > On ...
3 years, 8 months ago (2017-04-12 04:39:21 UTC) #20
pwnall
On 2017/04/12 04:39:21, Scott Hess wrote: > On 2017/04/12 02:01:19, pwnall wrote: > > On ...
3 years, 8 months ago (2017-04-12 05:18:07 UTC) #21
Scott Hess - ex-Googler
On 2017/04/12 05:18:07, pwnall wrote: > On 2017/04/12 04:39:21, Scott Hess wrote: > > On ...
3 years, 8 months ago (2017-04-12 05:23:39 UTC) #22
pwnall
On 2017/04/12 05:23:39, Scott Hess wrote: > On 2017/04/12 05:18:07, pwnall wrote: > > On ...
3 years, 8 months ago (2017-04-12 05:28:33 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812123002/40001
3 years, 8 months ago (2017-04-12 05:29:01 UTC) #25
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 05:33:56 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e28a080e6be1b875a471b23f4ce9...

Powered by Google App Engine
This is Rietveld 408576698