chrome/browser/content_settings/host_content_settings_map_factory.cc - Issue 2812113004: Write last_modified date to Content Settings in the PrefProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/host_content_settings_map_factory.cc

Issue 2812113004: Write last_modified date to Content Settings in the PrefProvider (Closed)

Patch Set: fix comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_pref_provider_unittest.cc ('k') | chrome/browser/content_settings/host_content_settings_map_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/host_content_settings_map_factory.cc

diff --git a/chrome/browser/content_settings/host_content_settings_map_factory.cc b/chrome/browser/content_settings/host_content_settings_map_factory.cc

index 1d0547c23e64dba326b52ae59f19117eccfd3441..c1a9a79d48e4064f181e7515d37a71b5934cba60 100644

--- a/chrome/browser/content_settings/host_content_settings_map_factory.cc

+++ b/chrome/browser/content_settings/host_content_settings_map_factory.cc

@@ -6,9 +6,11 @@

#include <utility>

+#include "base/feature_list.h"

#include "chrome/browser/prefs/pref_service_syncable_util.h"

#include "chrome/browser/profiles/off_the_record_profile_impl.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/common/chrome_features.h"

#include "components/content_settings/core/browser/host_content_settings_map.h"

#include "components/keyed_service/content/browser_context_dependency_manager.h"

#include "components/sync_preferences/pref_service_syncable.h"

@@ -74,10 +76,13 @@ scoped_refptr<RefcountedKeyedService>

GetForProfile(profile->GetOriginalProfile());

}

+ bool store_last_modified = base::FeatureList::IsEnabled(features::kTabsInCbd);

scoped_refptr<HostContentSettingsMap> settings_map(new HostContentSettingsMap(

profile->GetPrefs(),

profile->GetProfileType() == Profile::INCOGNITO_PROFILE,

- profile->GetProfileType() == Profile::GUEST_PROFILE));

+ profile->GetProfileType() == Profile::GUEST_PROFILE,

+ store_last_modified));

raymes 2017/04/20 00:07:57 Is it necessary to pass this in? Can we check it i

dullweber 2017/04/20 15:23:35 Whether the map stores these timestamps should dep

sync_preferences::PrefServiceSyncable* pref_service =

PrefServiceSyncableFromProfile(profile);