Write last_modified date to Content Settings in the PrefProvider

chrome/browser/content_settings/host_content_settings_map_factory.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 
 #include <utility>
 
+#include "base/feature_list.h"
 #include "chrome/browser/prefs/pref_service_syncable_util.h"
 #include "chrome/browser/profiles/off_the_record_profile_impl.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/common/chrome_features.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "components/sync_preferences/pref_service_syncable.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/features/features.h"
 
 #if BUILDFLAG(ENABLE_EXTENSIONS)
 #include "chrome/browser/extensions/extension_service.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/extension_system_provider.h"
@@ skipping 45 matching lines @@
 
   // If off the record, retrieve the host content settings map of the parent
   // profile in order to ensure the preferences have been migrated.
   // TODO(crbug.com/277296): Remove check that profile does not equal the
   // original profile once TestingProfile::ForceIncognito is gone.
   if (profile->GetProfileType() == Profile::INCOGNITO_PROFILE &&
       profile != profile->GetOriginalProfile()) {
     GetForProfile(profile->GetOriginalProfile());
   }
 
+  bool store_last_modified = base::FeatureList::IsEnabled(features::kTabsInCbd);
+
   scoped_refptr<HostContentSettingsMap> settings_map(new HostContentSettingsMap(
       profile->GetPrefs(),
       profile->GetProfileType() == Profile::INCOGNITO_PROFILE,
-      profile->GetProfileType() == Profile::GUEST_PROFILE));
+      profile->GetProfileType() == Profile::GUEST_PROFILE,
+      store_last_modified));

[raymes, 2017/04/20 00:07:57]

Is it necessary to pass this in? Can we check it inside the object instead?

[dullweber, 2017/04/20 15:23:35]

Whether the map stores these timestamps should depend on the new CBD dialog
because there would be no way to delete these history-like entries without the
new dialog. I need "chrome/common/chrome_features.h" to check the flag, which
isn't available inside the map.

 
   sync_preferences::PrefServiceSyncable* pref_service =
       PrefServiceSyncableFromProfile(profile);
   if (pref_service) {
     pref_service->RegisterMergeDataFinishedCallback(
         base::Bind(&HostContentSettingsMap::MigrateDomainScopedSettings,
                    settings_map->GetWeakPtr(), true /* after_sync */));
   }
 
 #if BUILDFLAG(ENABLE_EXTENSIONS)
@@ skipping 16 matching lines @@
   }
 #endif // BUILDFLAG(ENABLE_SUPERVISED_USERS)
 
   return settings_map;
 }
 
 content::BrowserContext* HostContentSettingsMapFactory::GetBrowserContextToUse(
     content::BrowserContext* context) const {
   return context;
 }