Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2812073002: Reduce the number of threads created by the load TaskTracker tests. (Closed)

Created:
3 years, 8 months ago by mbjorge
Modified:
3 years, 8 months ago
Reviewers:
robliao, fdoray
CC:
chromium-reviews, danakj+watch_chromium.org, fdoray+watch_chromium.org, gab+watch_chromium.org, robliao+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce the number of threads created by the load TaskTracker tests. Creating 300 threads on low memory devices fails, resulting in pthread_create returning EAGAIN and the tests crashing. Reduce the created threads by 25%, as local testing shows this is about the limit the devices can handle. BUG=710561 TESt=base_unittests on device Review-Url: https://codereview.chromium.org/2812073002 Cr-Commit-Position: refs/heads/master@{#463734} Committed: https://chromium.googlesource.com/chromium/src/+/311fdefdd2885ff3e93c8a16e469a41ed14cb1c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/task_scheduler/task_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
mbjorge
3 years, 8 months ago (2017-04-11 18:54:58 UTC) #2
robliao
lgtm
3 years, 8 months ago (2017-04-11 19:14:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812073002/1
3 years, 8 months ago (2017-04-11 19:24:44 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 19:52:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/311fdefdd2885ff3e93c8a16e469...

Powered by Google App Engine
This is Rietveld 408576698