Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2812056: Relanding http://codereview.chromium.org/2870050/show. (Closed)

Created:
10 years, 5 months ago by tfarina
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Base URL:
git://git.chromium.org/chromium.git
Visibility:
Public.

Description

Relanding http://codereview.chromium.org/2870050/show. It was needed to revert the first one because of a bad git merge. Now it should be safe. TBR=brettw BUG=None TEST=trybots Signed-off-by: Thiago Farina <tfarina@chromium.org>; Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52752

Patch Set 1 : #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -36 lines) Patch
M chrome/browser/renderer_host/render_view_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_delegate.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_delegate.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
10 years, 5 months ago (2010-07-16 03:44:47 UTC) #1
tyoshino (SeeGerritForStatus)
On 2010/07/16 03:44:47, tfarina wrote: > Not familiar with the change, but the change you ...
10 years, 5 months ago (2010-07-16 03:56:35 UTC) #2
tfarina
10 years, 5 months ago (2010-07-16 14:53:16 UTC) #3
On 2010/07/16 03:56:35, tyoshino wrote:
> On 2010/07/16 03:44:47, tfarina wrote:
> > 
> 
> Not familiar with the change, but the change you made from the original CL
looks
> good to me (CanBlur is removed from tab_contents_delegate.cc)
> 
> Please make sure the failure on try bots are not problem.

I think now it will be fine, linux passed, mac is still running but is going to
be fine too, remaining win solo.
Please, may you have another look?

Powered by Google App Engine
This is Rietveld 408576698