Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2812053004: Update FWMP in TPM (Closed)

Created:
3 years, 8 months ago by emaxx
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Update FWMP in TPM As part of enrollment, the firmware management parameters (FWMP) partition from TPM has to be set including the flags to mark if the devmode is blocked. The update has to be done before the TPM is locked but after the policy is retrieved. It is implemented by including additional step in enrollment process that makes the D-Bus call to cryptohome to set the data in FWMP. Similarly when the device is deprovisioned, the firmware management parameters are removed from TPM when it is established that it is a consumer owned device. BUG=685144 Review-Url: https://codereview.chromium.org/2727713003 Cr-Commit-Position: refs/heads/master@{#462886} (cherry picked from commit d6dbbe9a3f1a62bc6ec0414bd4bbd5d4c2d9f833) Review-Url: https://codereview.chromium.org/2812053004 . Cr-Commit-Position: refs/branch-heads/3029@{#678} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/8a9654349f513c585696ad788dcb5b37b1283211

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -58 lines) Patch
M chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.h View 3 chunks +28 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc View 5 chunks +42 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/policy/enrollment_handler_chromeos.h View 2 chunks +17 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc View 5 chunks +66 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/settings/install_attributes.h View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/install_attributes.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/install_attributes_unittest.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M chromeos/dbus/cryptohome_client.h View 2 chunks +16 lines, -0 lines 0 comments Download
M chromeos/dbus/cryptohome_client.cc View 2 chunks +36 lines, -31 lines 0 comments Download
M chromeos/dbus/fake_cryptohome_client.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_cryptohome_client.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chromeos/dbus/mock_cryptohome_client.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
emaxx
3 years, 8 months ago (2017-04-12 17:45:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a9654349f513c585696ad788dcb5b37b1283211.

Powered by Google App Engine
This is Rietveld 408576698