Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2812013006: [turbofan] Fix typing rule for CheckBounds. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix typing rule for CheckBounds. As of crrev.com/2760213003, the CheckBounds operator passes a truncation that identfies zero and minus zero. However that was not reflected in the typing rule, and as such the type of CheckBounds(-0,length) was always Type::None. That confused the typed alias analysis in the LoadElimination and led to ignoring StoreElement nodes. BUG=chromium:708050 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2812013006 Cr-Commit-Position: refs/heads/master@{#44598} Committed: https://chromium.googlesource.com/v8/v8/+/483812d46cf96e26500b93b5b3d1cb9737236b2b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M src/compiler/typer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-708050-1.js View 1 chunk +17 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-708050-2.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-12 08:36:24 UTC) #1
Jarin
lgtm
3 years, 8 months ago (2017-04-12 08:41:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812013006/1
3 years, 8 months ago (2017-04-12 08:42:16 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 09:02:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/483812d46cf96e26500b93b5b3d1cb97372...

Powered by Google App Engine
This is Rietveld 408576698