Fix some build deps for //extensions/browser/api/guest_view, //extensions/common, //extensions/rend…

Fix some build deps for //extensions/browser/api/guest_view, //extensions/common, //extensions/renderer.

//extensions/browser/api/guest_view: guest_view_internal_api.h includes extensions/browser/extension_function.h. The same problem exists for other subdirs of e/b/api/guest_view/. Cannot add //extensions/browser as a dep to //extensions/browser/api/guest_view because that would create a circular dependency. 
Merge all those subdir files into //extensions/browser/api and specify all the public_deps of extension_function.h there. (This doesn't fix the underlying circular includes issue, but does clean things up a little bit.)

Example failure:
In file included from gen/extensions/browser/api/generated_api_registration.cc:9:
In file included from ../../extensions/browser/api/guest_view/web_view/web_view_internal_api.h:15:
In file included from ../../extensions/browser/guest_view/web_view/web_view_guest.h:14:
In file included from ../../components/guest_view/browser/guest_view.h:9:
In file included from ../../components/guest_view/browser/guest_view_base.h:15:
In file included from ../../components/zoom/zoom_observer.h:8:
In file included from ../../components/zoom/zoom_controller.h:16:
In file included from ../../content/public/browser/web_contents_observer.h:15:
In file included from ../../content/public/browser/navigation_controller.h:24:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error: 'openssl/opensslconf.h' file not found

//extensions/common: move //content/public/common to public_deps, as extensions/common/extension_messages.h includes files from there.
//extensions/renderer: add dep on //extensions/common, as many files in extensions/renderer include extensions/common/extension_messages.h.

Example failure for both of those:
In file included from ../../extensions/renderer/service_worker_request_sender.cc:9:
In file included from ../../extensions/common/extension_messages.h:16:
In file included from ../../content/public/common/common_param_traits.h:24:
In file included from ../../content/public/common/common_param_traits_macros.h:13:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error: 'openssl/opensslconf.h' file not found

BUG=711670
Review-Url: https://codereview.chromium.org/2812013003
Cr-Commit-Position: refs/heads/master@{#464802}
Committed: https://chromium.googlesource.com/chromium/src/+/2dbc3ed538ce6f3470af81dab163ca6e3c018bbc

[mattm, 2017-04-12 03:06:43]

Description was changed from

==========
Fix some build deps for //extensions/browser/api/guest_view,
//extensions/common, //extensions/renderer.

//extensions/browser/api/guest_view: guest_view_internal_api.h includes
extensions/browser/extension_function.h. Cannot add //extensions/browser as a
dep to //extensions/browser/api/guest_view because that would create a circular
dependency. Hence specifying all the public_deps of extension_function.h here
instead. This is a bit ugly but I dunno a better fix would require a larger
BUILD file refactoring.

Example failure:
In file included from
gen/extensions/browser/api/generated_api_registration.cc:9:
In file included from
../../extensions/browser/api/guest_view/web_view/web_view_internal_api.h:15:
In file included from
../../extensions/browser/guest_view/web_view/web_view_guest.h:14:
In file included from ../../components/guest_view/browser/guest_view.h:9:
In file included from ../../components/guest_view/browser/guest_view_base.h:15:
In file included from ../../components/zoom/zoom_observer.h:8:
In file included from ../../components/zoom/zoom_controller.h:16:
In file included from ../../content/public/browser/web_contents_observer.h:15:
In file included from ../../content/public/browser/navigation_controller.h:24:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

//extensions/common: move //content/public/common to public_deps, as
extensions/common/extension_messages.h includes files from there.
//extensions/renderer: add dep on //extensions/common, as many files in
extensions/renderer include extensions/common/extension_messages.h.

Example failure for both of those:
In file included from
../../extensions/renderer/service_worker_request_sender.cc:9:
In file included from ../../extensions/common/extension_messages.h:16:
In file included from ../../content/public/common/common_param_traits.h:24:
In file included from
../../content/public/common/common_param_traits_macros.h:13:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

BUG=none
==========

to

==========
Fix some build deps for //extensions/browser/api/guest_view,
//extensions/common, //extensions/renderer.

//extensions/browser/api/guest_view: guest_view_internal_api.h includes
extensions/browser/extension_function.h. Cannot add //extensions/browser as a
dep to //extensions/browser/api/guest_view because that would create a circular
dependency. Hence specifying all the public_deps of extension_function.h here
instead. This is a bit ugly but a better fix would require a larger BUILD file
refactoring.

Example failure:
In file included from
gen/extensions/browser/api/generated_api_registration.cc:9:
In file included from
../../extensions/browser/api/guest_view/web_view/web_view_internal_api.h:15:
In file included from
../../extensions/browser/guest_view/web_view/web_view_guest.h:14:
In file included from ../../components/guest_view/browser/guest_view.h:9:
In file included from ../../components/guest_view/browser/guest_view_base.h:15:
In file included from ../../components/zoom/zoom_observer.h:8:
In file included from ../../components/zoom/zoom_controller.h:16:
In file included from ../../content/public/browser/web_contents_observer.h:15:
In file included from ../../content/public/browser/navigation_controller.h:24:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

//extensions/common: move //content/public/common to public_deps, as
extensions/common/extension_messages.h includes files from there.
//extensions/renderer: add dep on //extensions/common, as many files in
extensions/renderer include extensions/common/extension_messages.h.

Example failure for both of those:
In file included from
../../extensions/renderer/service_worker_request_sender.cc:9:
In file included from ../../extensions/common/extension_messages.h:16:
In file included from ../../content/public/common/common_param_traits.h:24:
In file included from
../../content/public/common/common_param_traits_macros.h:13:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

BUG=none
==========

[mattm, 2017-04-12 03:13:53]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 03:14:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-04-12 03:30:07]

mattm@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[mattm, 2017-04-12 03:30:08]

See CL description for details.

(Build failures can be reproduced by building on macOS with SDK 10.11 or 10.12.)

[commit-bot: I haz the power, 2017-04-12 04:14:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 04:14:26]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-04-12 15:44:27]

rdevlin.cronin@chromium.org changed reviewers:
+ dpranke@chromium.org

[Devlin, 2017-04-12 15:44:28]

extensions/[common|renderer] changes are fine.

The browser change makes me wonder.

It seems wrong that we'd have to do this.  I think the fundamental problem is
that we have:

chrome/browser/extensions/<stuff>
chrome/browser/extensions/<subdirs>/<stuff>

and c/b/e/<subdirs>/<stuff> depends on c/b/e/<stuff>, but *also* has separate
BUILD.gn files.  We have a similar directory/dependency structure in ui:
chrome/browser/ui/<stuff - e.g. browser.h>
chrome/browser/ui/<subdir - e.g. views>/<stuff that depends on c/b/ui/<stuff>>

It looks like in that case, we only have separate BUILD.gns for the things that
are truly independent of c/b/ui (which is very little).

I think the right answer here might be that we shouldn't have BUILD.gns in the
subdirectories that have "upper" dependencies (similar to what c/b/ui does), but
that has the unfortunate effect of leading to monolithic build files.

Dirk, is there an door #3?  Or is that the right approach?

[mattm, 2017-04-13 01:15:42]

On 2017/04/12 15:44:28, Devlin wrote:
> extensions/[common|renderer] changes are fine.
> 
> The browser change makes me wonder.
> 
> It seems wrong that we'd have to do this.  I think the fundamental problem is
> that we have:
> 
> chrome/browser/extensions/<stuff>
> chrome/browser/extensions/<subdirs>/<stuff>
> 
> and c/b/e/<subdirs>/<stuff> depends on c/b/e/<stuff>, but *also* has separate
> BUILD.gn files.  We have a similar directory/dependency structure in ui:
> chrome/browser/ui/<stuff - e.g. browser.h>
> chrome/browser/ui/<subdir - e.g. views>/<stuff that depends on c/b/ui/<stuff>>
> 
> It looks like in that case, we only have separate BUILD.gns for the things
that
> are truly independent of c/b/ui (which is very little).

There is actually a problem in c/b/ui/views too:
https://codereview.chromium.org/2806293004/

> I think the right answer here might be that we shouldn't have BUILD.gns in the
> subdirectories that have "upper" dependencies (similar to what c/b/ui does),
but
> that has the unfortunate effect of leading to monolithic build files.
> 
> Dirk, is there an door #3?  Or is that the right approach?

[Dirk Pranke, 2017-04-13 01:38:31]

There isn't really a door #3. Your description is correct, except that the
issues are really related to targets, not files (i.e., two targets in the same
file might have the same problem).

If the two targets really are truly interrelated, and they're both compiled the
same way, then they're probably better off as a single target.

[mattm, 2017-04-14 18:42:27]

On 2017/04/13 01:38:31, Dirk Pranke wrote:
> There isn't really a door #3. Your description is correct, except that the
> issues are really related to targets, not files (i.e., two targets in the same
> file might have the same problem).
> 
> If the two targets really are truly interrelated, and they're both compiled
the
> same way, then they're probably better off as a single target.

selfish proposal: land this CL as-is and file a bug for someone to fix the
deeper issues?

[mattm, 2017-04-14 18:45:21]

Description was changed from

==========
Fix some build deps for //extensions/browser/api/guest_view,
//extensions/common, //extensions/renderer.

//extensions/browser/api/guest_view: guest_view_internal_api.h includes
extensions/browser/extension_function.h. Cannot add //extensions/browser as a
dep to //extensions/browser/api/guest_view because that would create a circular
dependency. Hence specifying all the public_deps of extension_function.h here
instead. This is a bit ugly but a better fix would require a larger BUILD file
refactoring.

Example failure:
In file included from
gen/extensions/browser/api/generated_api_registration.cc:9:
In file included from
../../extensions/browser/api/guest_view/web_view/web_view_internal_api.h:15:
In file included from
../../extensions/browser/guest_view/web_view/web_view_guest.h:14:
In file included from ../../components/guest_view/browser/guest_view.h:9:
In file included from ../../components/guest_view/browser/guest_view_base.h:15:
In file included from ../../components/zoom/zoom_observer.h:8:
In file included from ../../components/zoom/zoom_controller.h:16:
In file included from ../../content/public/browser/web_contents_observer.h:15:
In file included from ../../content/public/browser/navigation_controller.h:24:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

//extensions/common: move //content/public/common to public_deps, as
extensions/common/extension_messages.h includes files from there.
//extensions/renderer: add dep on //extensions/common, as many files in
extensions/renderer include extensions/common/extension_messages.h.

Example failure for both of those:
In file included from
../../extensions/renderer/service_worker_request_sender.cc:9:
In file included from ../../extensions/common/extension_messages.h:16:
In file included from ../../content/public/common/common_param_traits.h:24:
In file included from
../../content/public/common/common_param_traits_macros.h:13:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

BUG=none
==========

to

==========
Fix some build deps for //extensions/browser/api/guest_view,
//extensions/common, //extensions/renderer.

//extensions/browser/api/guest_view: guest_view_internal_api.h includes
extensions/browser/extension_function.h. Cannot add //extensions/browser as a
dep to //extensions/browser/api/guest_view because that would create a circular
dependency. Hence specifying all the public_deps of extension_function.h here
instead. This is a bit ugly but a better fix would require a larger BUILD file
refactoring.

Example failure:
In file included from
gen/extensions/browser/api/generated_api_registration.cc:9:
In file included from
../../extensions/browser/api/guest_view/web_view/web_view_internal_api.h:15:
In file included from
../../extensions/browser/guest_view/web_view/web_view_guest.h:14:
In file included from ../../components/guest_view/browser/guest_view.h:9:
In file included from ../../components/guest_view/browser/guest_view_base.h:15:
In file included from ../../components/zoom/zoom_observer.h:8:
In file included from ../../components/zoom/zoom_controller.h:16:
In file included from ../../content/public/browser/web_contents_observer.h:15:
In file included from ../../content/public/browser/navigation_controller.h:24:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

//extensions/common: move //content/public/common to public_deps, as
extensions/common/extension_messages.h includes files from there.
//extensions/renderer: add dep on //extensions/common, as many files in
extensions/renderer include extensions/common/extension_messages.h.

Example failure for both of those:
In file included from
../../extensions/renderer/service_worker_request_sender.cc:9:
In file included from ../../extensions/common/extension_messages.h:16:
In file included from ../../content/public/common/common_param_traits.h:24:
In file included from
../../content/public/common/common_param_traits_macros.h:13:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

BUG=711670
==========

[Devlin, 2017-04-14 19:31:06]

On 2017/04/14 18:42:27, mattm wrote:
> On 2017/04/13 01:38:31, Dirk Pranke wrote:
> > There isn't really a door #3. Your description is correct, except that the
> > issues are really related to targets, not files (i.e., two targets in the
same
> > file might have the same problem).
> > 
> > If the two targets really are truly interrelated, and they're both compiled
> the
> > same way, then they're probably better off as a single target.
> 
> selfish proposal: land this CL as-is and file a bug for someone to fix the
> deeper issues?

Could we just remove api/guest_view/BUILD.gn and add the files directly to
extensions/browser/api/BUILD.gn?  It's also not a perma-fix, but might be a
little cleaner than this.  WDYT?

[mattm, 2017-04-14 20:01:03]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 20:01:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2017-04-14 20:03:55]

On 2017/04/14 19:31:06, Devlin wrote:
> On 2017/04/14 18:42:27, mattm wrote:
> > On 2017/04/13 01:38:31, Dirk Pranke wrote:
> > > There isn't really a door #3. Your description is correct, except that the
> > > issues are really related to targets, not files (i.e., two targets in the
> same
> > > file might have the same problem).
> > > 
> > > If the two targets really are truly interrelated, and they're both
compiled
> > the
> > > same way, then they're probably better off as a single target.
> > 
> > selfish proposal: land this CL as-is and file a bug for someone to fix the
> > deeper issues?
> 
> Could we just remove api/guest_view/BUILD.gn and add the files directly to
> extensions/browser/api/BUILD.gn?  It's also not a perma-fix, but might be a
> little cleaner than this.  WDYT?

Done.

It does make things a bit cleaner (esp since I see now there were actually
multiple sub-dirs with the same problem). No other targets directly depended on
any of these targets anyway.

But, as you say, It doesn't solve the underlying issue, since they are still
including files from a target from one level higher than e/b/api/BUILD.gn.

[mattm, 2017-04-14 20:06:08]

Description was changed from

==========
Fix some build deps for //extensions/browser/api/guest_view,
//extensions/common, //extensions/renderer.

//extensions/browser/api/guest_view: guest_view_internal_api.h includes
extensions/browser/extension_function.h. Cannot add //extensions/browser as a
dep to //extensions/browser/api/guest_view because that would create a circular
dependency. Hence specifying all the public_deps of extension_function.h here
instead. This is a bit ugly but a better fix would require a larger BUILD file
refactoring.

Example failure:
In file included from
gen/extensions/browser/api/generated_api_registration.cc:9:
In file included from
../../extensions/browser/api/guest_view/web_view/web_view_internal_api.h:15:
In file included from
../../extensions/browser/guest_view/web_view/web_view_guest.h:14:
In file included from ../../components/guest_view/browser/guest_view.h:9:
In file included from ../../components/guest_view/browser/guest_view_base.h:15:
In file included from ../../components/zoom/zoom_observer.h:8:
In file included from ../../components/zoom/zoom_controller.h:16:
In file included from ../../content/public/browser/web_contents_observer.h:15:
In file included from ../../content/public/browser/navigation_controller.h:24:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

//extensions/common: move //content/public/common to public_deps, as
extensions/common/extension_messages.h includes files from there.
//extensions/renderer: add dep on //extensions/common, as many files in
extensions/renderer include extensions/common/extension_messages.h.

Example failure for both of those:
In file included from
../../extensions/renderer/service_worker_request_sender.cc:9:
In file included from ../../extensions/common/extension_messages.h:16:
In file included from ../../content/public/common/common_param_traits.h:24:
In file included from
../../content/public/common/common_param_traits_macros.h:13:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

BUG=711670
==========

to

==========
Fix some build deps for //extensions/browser/api/guest_view,
//extensions/common, //extensions/renderer.

//extensions/browser/api/guest_view: guest_view_internal_api.h includes
extensions/browser/extension_function.h. The same problem exists for other
subdirs of e/b/api/guest_view/. Cannot add //extensions/browser as a dep to
//extensions/browser/api/guest_view because that would create a circular
dependency. 
Merge all those subdir files into //extensions/browser/api and specify all the
public_deps of extension_function.h there. (This doesn't fix the underlying
circular includes issue, but does clean things up a little bit.)

Example failure:
In file included from
gen/extensions/browser/api/generated_api_registration.cc:9:
In file included from
../../extensions/browser/api/guest_view/web_view/web_view_internal_api.h:15:
In file included from
../../extensions/browser/guest_view/web_view/web_view_guest.h:14:
In file included from ../../components/guest_view/browser/guest_view.h:9:
In file included from ../../components/guest_view/browser/guest_view_base.h:15:
In file included from ../../components/zoom/zoom_observer.h:8:
In file included from ../../components/zoom/zoom_controller.h:16:
In file included from ../../content/public/browser/web_contents_observer.h:15:
In file included from ../../content/public/browser/navigation_controller.h:24:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

//extensions/common: move //content/public/common to public_deps, as
extensions/common/extension_messages.h includes files from there.
//extensions/renderer: add dep on //extensions/common, as many files in
extensions/renderer include extensions/common/extension_messages.h.

Example failure for both of those:
In file included from
../../extensions/renderer/service_worker_request_sender.cc:9:
In file included from ../../extensions/common/extension_messages.h:16:
In file included from ../../content/public/common/common_param_traits.h:24:
In file included from
../../content/public/common/common_param_traits_macros.h:13:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

BUG=711670
==========

[Devlin, 2017-04-14 20:10:42]

lgtm for this as a band-aid.  Thanks for the patch!

[mattm, 2017-04-14 20:19:26]

The CQ bit was unchecked by mattm@chromium.org

[mattm, 2017-04-14 20:19:30]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2017-04-14 20:19:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 21:43:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492201170311730,
"parent_rev": "18281c41a2b809619b3f533c76033e1a14729944", "commit_rev":
"2dbc3ed538ce6f3470af81dab163ca6e3c018bbc"}

[commit-bot: I haz the power, 2017-04-14 21:44:55]

Description was changed from

==========
Fix some build deps for //extensions/browser/api/guest_view,
//extensions/common, //extensions/renderer.

//extensions/browser/api/guest_view: guest_view_internal_api.h includes
extensions/browser/extension_function.h. The same problem exists for other
subdirs of e/b/api/guest_view/. Cannot add //extensions/browser as a dep to
//extensions/browser/api/guest_view because that would create a circular
dependency. 
Merge all those subdir files into //extensions/browser/api and specify all the
public_deps of extension_function.h there. (This doesn't fix the underlying
circular includes issue, but does clean things up a little bit.)

Example failure:
In file included from
gen/extensions/browser/api/generated_api_registration.cc:9:
In file included from
../../extensions/browser/api/guest_view/web_view/web_view_internal_api.h:15:
In file included from
../../extensions/browser/guest_view/web_view/web_view_guest.h:14:
In file included from ../../components/guest_view/browser/guest_view.h:9:
In file included from ../../components/guest_view/browser/guest_view_base.h:15:
In file included from ../../components/zoom/zoom_observer.h:8:
In file included from ../../components/zoom/zoom_controller.h:16:
In file included from ../../content/public/browser/web_contents_observer.h:15:
In file included from ../../content/public/browser/navigation_controller.h:24:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

//extensions/common: move //content/public/common to public_deps, as
extensions/common/extension_messages.h includes files from there.
//extensions/renderer: add dep on //extensions/common, as many files in
extensions/renderer include extensions/common/extension_messages.h.

Example failure for both of those:
In file included from
../../extensions/renderer/service_worker_request_sender.cc:9:
In file included from ../../extensions/common/extension_messages.h:16:
In file included from ../../content/public/common/common_param_traits.h:24:
In file included from
../../content/public/common/common_param_traits_macros.h:13:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

BUG=711670
==========

to

==========
Fix some build deps for //extensions/browser/api/guest_view,
//extensions/common, //extensions/renderer.

//extensions/browser/api/guest_view: guest_view_internal_api.h includes
extensions/browser/extension_function.h. The same problem exists for other
subdirs of e/b/api/guest_view/. Cannot add //extensions/browser as a dep to
//extensions/browser/api/guest_view because that would create a circular
dependency. 
Merge all those subdir files into //extensions/browser/api and specify all the
public_deps of extension_function.h there. (This doesn't fix the underlying
circular includes issue, but does clean things up a little bit.)

Example failure:
In file included from
gen/extensions/browser/api/generated_api_registration.cc:9:
In file included from
../../extensions/browser/api/guest_view/web_view/web_view_internal_api.h:15:
In file included from
../../extensions/browser/guest_view/web_view/web_view_guest.h:14:
In file included from ../../components/guest_view/browser/guest_view.h:9:
In file included from ../../components/guest_view/browser/guest_view_base.h:15:
In file included from ../../components/zoom/zoom_observer.h:8:
In file included from ../../components/zoom/zoom_controller.h:16:
In file included from ../../content/public/browser/web_contents_observer.h:15:
In file included from ../../content/public/browser/navigation_controller.h:24:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

//extensions/common: move //content/public/common to public_deps, as
extensions/common/extension_messages.h includes files from there.
//extensions/renderer: add dep on //extensions/common, as many files in
extensions/renderer include extensions/common/extension_messages.h.

Example failure for both of those:
In file included from
../../extensions/renderer/service_worker_request_sender.cc:9:
In file included from ../../extensions/common/extension_messages.h:16:
In file included from ../../content/public/common/common_param_traits.h:24:
In file included from
../../content/public/common/common_param_traits_macros.h:13:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error:
'openssl/opensslconf.h' file not found

BUG=711670

Review-Url: https://codereview.chromium.org/2812013003
Cr-Commit-Position: refs/heads/master@{#464802}
Committed:
https://chromium.googlesource.com/chromium/src/+/2dbc3ed538ce6f3470af81dab163...
==========

[commit-bot: I haz the power, 2017-04-14 21:45:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2dbc3ed538ce6f3470af81dab163...