Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2812013002:
Re-enable TransferCookiesUnaffiliated test everywhere except MSAN,ASAN (Closed)
DescriptionRe-enable TransferCookiesUnaffiliated test everywhere except MSAN,ASAN
This enables back the tests TransferCookiesUnaffiliated and
PRE_TransferCookiesUnaffiliated, as long as they are running with
neither MEMORY_SANITIZER nor ADDRESS_SANITIZER.
These tests were flaky probably only because they were timing out on
MSAN or ASAN.
BUG=683161
Review-Url: https://codereview.chromium.org/2812013002
Cr-Commit-Position: refs/heads/master@{#463834}
Committed: https://chromium.googlesource.com/chromium/src/+/1e04e1de4401bf105333158e4cb314fa834c5fa8
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix nit #Messages
Total messages: 21 (16 generated)
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
emaxx@chromium.org changed reviewers: + achuith@chromium.org
Achuith, PTAL.
Description was changed from ========== Disable TransferCookiesUnaffiliated test only under MSAN,ASAN This enables back the tests TransferCookiesUnaffiliated and PRE_TransferCookiesUnaffiliated, as soon as they are running with neither MEMORY_SANITIZER nor ADDRESS_SANITIZER. These tests were flaky probably only because they were timing out on MSAN or ASAN. BUG=683161 ========== to ========== Re-enable TransferCookiesUnaffiliated test anywhere except MSAN,ASAN This enables back the tests TransferCookiesUnaffiliated and PRE_TransferCookiesUnaffiliated, as soon as they are running with neither MEMORY_SANITIZER nor ADDRESS_SANITIZER. These tests were flaky probably only because they were timing out on MSAN or ASAN. BUG=683161 ==========
lgtm https://codereview.chromium.org/2812013002/diff/1/chrome/browser/chromeos/log... File chrome/browser/chromeos/login/saml/saml_browsertest.cc (right): https://codereview.chromium.org/2812013002/diff/1/chrome/browser/chromeos/log... chrome/browser/chromeos/login/saml/saml_browsertest.cc:1358: #endif maybe a newline after this line?
Description was changed from ========== Re-enable TransferCookiesUnaffiliated test anywhere except MSAN,ASAN This enables back the tests TransferCookiesUnaffiliated and PRE_TransferCookiesUnaffiliated, as soon as they are running with neither MEMORY_SANITIZER nor ADDRESS_SANITIZER. These tests were flaky probably only because they were timing out on MSAN or ASAN. BUG=683161 ========== to ========== Re-enable TransferCookiesUnaffiliated test anywhere except MSAN,ASAN This enables back the tests TransferCookiesUnaffiliated and PRE_TransferCookiesUnaffiliated, as long as they are running with neither MEMORY_SANITIZER nor ADDRESS_SANITIZER. These tests were flaky probably only because they were timing out on MSAN or ASAN. BUG=683161 ==========
Description was changed from ========== Re-enable TransferCookiesUnaffiliated test anywhere except MSAN,ASAN This enables back the tests TransferCookiesUnaffiliated and PRE_TransferCookiesUnaffiliated, as long as they are running with neither MEMORY_SANITIZER nor ADDRESS_SANITIZER. These tests were flaky probably only because they were timing out on MSAN or ASAN. BUG=683161 ========== to ========== Re-enable TransferCookiesUnaffiliated test everywhere except MSAN,ASAN This enables back the tests TransferCookiesUnaffiliated and PRE_TransferCookiesUnaffiliated, as long as they are running with neither MEMORY_SANITIZER nor ADDRESS_SANITIZER. These tests were flaky probably only because they were timing out on MSAN or ASAN. BUG=683161 ==========
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2812013002/diff/1/chrome/browser/chromeos/log... File chrome/browser/chromeos/login/saml/saml_browsertest.cc (right): https://codereview.chromium.org/2812013002/diff/1/chrome/browser/chromeos/log... chrome/browser/chromeos/login/saml/saml_browsertest.cc:1358: #endif On 2017/04/11 18:52:14, achuithb wrote: > maybe a newline after this line? Done.
The CQ bit was checked by emaxx@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org Link to the patchset: https://codereview.chromium.org/2812013002/#ps20001 (title: "Fix nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491952610480400,
"parent_rev": "65aaa85ee5c1ff86742d9a426348afc7be78568e", "commit_rev":
"1e04e1de4401bf105333158e4cb314fa834c5fa8"}
Message was sent while issue was closed.
Description was changed from ========== Re-enable TransferCookiesUnaffiliated test everywhere except MSAN,ASAN This enables back the tests TransferCookiesUnaffiliated and PRE_TransferCookiesUnaffiliated, as long as they are running with neither MEMORY_SANITIZER nor ADDRESS_SANITIZER. These tests were flaky probably only because they were timing out on MSAN or ASAN. BUG=683161 ========== to ========== Re-enable TransferCookiesUnaffiliated test everywhere except MSAN,ASAN This enables back the tests TransferCookiesUnaffiliated and PRE_TransferCookiesUnaffiliated, as long as they are running with neither MEMORY_SANITIZER nor ADDRESS_SANITIZER. These tests were flaky probably only because they were timing out on MSAN or ASAN. BUG=683161 Review-Url: https://codereview.chromium.org/2812013002 Cr-Commit-Position: refs/heads/master@{#463834} Committed: https://chromium.googlesource.com/chromium/src/+/1e04e1de4401bf105333158e4cb3... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/1e04e1de4401bf105333158e4cb3... |
