Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 2812003006: Move gpu jason file data generation to build time. (Closed)

Created:
3 years, 8 months ago by Zhenyao Mo
Modified:
3 years, 8 months ago
Reviewers:
brettw, piman
CC:
chromium-reviews, Ken Russell (switch to Gerrit), brettw
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move gpu jason file data generation to build time. BUG=691703 TEST=chrome R=piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2812003006 Cr-Commit-Position: refs/heads/master@{#464235} Committed: https://chromium.googlesource.com/chromium/src/+/ede160c50d85e5fd546ec8134714b35c71c0e2f1

Patch Set 1 #

Patch Set 2 : remove git-format from build time generated files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -11316 lines) Patch
M gpu/config/BUILD.gn View 4 chunks +33 lines, -8 lines 0 comments Download
D gpu/config/gpu_driver_bug_list_arrays_and_structs_autogen.h View 1 chunk +0 lines, -2126 lines 0 comments Download
D gpu/config/gpu_driver_bug_list_autogen.h View 1 chunk +0 lines, -22 lines 0 comments Download
D gpu/config/gpu_driver_bug_list_autogen.cc View 1 chunk +0 lines, -4528 lines 0 comments Download
D gpu/config/gpu_driver_bug_list_exceptions_autogen.h View 1 chunk +0 lines, -68 lines 0 comments Download
M gpu/config/process_json.py View 1 5 chunks +134 lines, -88 lines 0 comments Download
D gpu/config/software_rendering_list_arrays_and_structs_autogen.h View 1 chunk +0 lines, -1748 lines 0 comments Download
D gpu/config/software_rendering_list_autogen.h View 1 chunk +0 lines, -22 lines 0 comments Download
D gpu/config/software_rendering_list_autogen.cc View 1 chunk +0 lines, -2182 lines 0 comments Download
D gpu/config/software_rendering_list_exceptions_autogen.h View 1 chunk +0 lines, -524 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Zhenyao Mo
piman: Please review kbr, brettw: FYI (feel free to also review)
3 years, 8 months ago (2017-04-12 21:53:59 UTC) #4
Zhenyao Mo
Note that I didn't generate platform specific entries in this CL. All entries are still ...
3 years, 8 months ago (2017-04-12 21:55:25 UTC) #5
Zhenyao Mo
On 2017/04/12 21:55:25, Zhenyao Mo wrote: > Note that I didn't generate platform specific entries ...
3 years, 8 months ago (2017-04-12 21:57:46 UTC) #6
piman
lgtm
3 years, 8 months ago (2017-04-12 22:05:28 UTC) #7
Zhenyao Mo
A tiny change: as brettw pointed out to me offline, we can't rely on the ...
3 years, 8 months ago (2017-04-12 22:23:52 UTC) #9
piman
lgtm
3 years, 8 months ago (2017-04-12 22:54:42 UTC) #11
brettw
Build file looks reasonable, I didn't look at the rest.
3 years, 8 months ago (2017-04-12 23:07:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812003006/20001
3 years, 8 months ago (2017-04-12 23:53:37 UTC) #17
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 01:47:42 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ede160c50d85e5fd546ec8134714...

Powered by Google App Engine
This is Rietveld 408576698