Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Side by Side Diff: third_party/WebKit/Source/core/workers/WorkerLoaderProxy.cpp

Issue 2811993007: Worker: Remove cross-thread PostTask functions from WorkerLoaderProxy (Closed)
Patch Set: address review comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/workers/WorkerLoaderProxy.h" 5 #include "core/workers/WorkerLoaderProxy.h"
6 6
7 #include "core/loader/ThreadableLoadingContext.h" 7 #include "core/loader/ThreadableLoadingContext.h"
8 8
9 namespace blink { 9 namespace blink {
10 10
11 WorkerLoaderProxy::WorkerLoaderProxy( 11 WorkerLoaderProxy::WorkerLoaderProxy(
12 WorkerLoaderProxyProvider* loader_proxy_provider) 12 WorkerLoaderProxyProvider* loader_proxy_provider)
13 : loader_proxy_provider_(loader_proxy_provider) {} 13 : loader_proxy_provider_(loader_proxy_provider) {}
14 14
15 WorkerLoaderProxy::~WorkerLoaderProxy() { 15 WorkerLoaderProxy::~WorkerLoaderProxy() {
16 DCHECK(!loader_proxy_provider_); 16 DCHECK(!loader_proxy_provider_);
17 } 17 }
18 18
19 void WorkerLoaderProxy::DetachProvider( 19 void WorkerLoaderProxy::DetachProvider(
20 WorkerLoaderProxyProvider* proxy_provider) { 20 WorkerLoaderProxyProvider* proxy_provider) {
21 MutexLocker locker(lock_);
22 DCHECK(IsMainThread()); 21 DCHECK(IsMainThread());
23 DCHECK_EQ(proxy_provider, loader_proxy_provider_); 22 DCHECK_EQ(proxy_provider, loader_proxy_provider_);
24 loader_proxy_provider_ = nullptr; 23 loader_proxy_provider_ = nullptr;
25 } 24 }
26 25
27 void WorkerLoaderProxy::PostTaskToLoader(
28 const WebTraceLocation& location,
29 std::unique_ptr<WTF::CrossThreadClosure> task) {
30 MutexLocker locker(lock_);
31 DCHECK(!IsMainThread());
32 if (!loader_proxy_provider_)
33 return;
34 loader_proxy_provider_->PostTaskToLoader(location, std::move(task));
35 }
36
37 void WorkerLoaderProxy::PostTaskToWorkerGlobalScope(
38 const WebTraceLocation& location,
39 std::unique_ptr<WTF::CrossThreadClosure> task) {
40 DCHECK(IsMainThread());
41 // Note: No locking needed for the access from the main thread.
42 if (!loader_proxy_provider_)
43 return;
44 loader_proxy_provider_->PostTaskToWorkerGlobalScope(location,
45 std::move(task));
46 }
47
48 ThreadableLoadingContext* WorkerLoaderProxy::GetThreadableLoadingContext() { 26 ThreadableLoadingContext* WorkerLoaderProxy::GetThreadableLoadingContext() {
49 DCHECK(IsMainThread()); 27 DCHECK(IsMainThread());
50 // Note: No locking needed for the access from the main thread.
51 if (!loader_proxy_provider_) 28 if (!loader_proxy_provider_)
52 return nullptr; 29 return nullptr;
53 DCHECK( 30 DCHECK(
54 loader_proxy_provider_->GetThreadableLoadingContext()->IsContextThread()); 31 loader_proxy_provider_->GetThreadableLoadingContext()->IsContextThread());
55 return loader_proxy_provider_->GetThreadableLoadingContext(); 32 return loader_proxy_provider_->GetThreadableLoadingContext();
56 } 33 }
57 34
58 } // namespace blink 35 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698