Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2811993005: Revert of When HttpNetworkTransaction encounters QUIC errors, retry the request (Closed)

Created:
3 years, 8 months ago by jdoerrie
Modified:
3 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of When HttpNetworkTransaction encounters QUIC errors, retry the request (patchset #3 id:40001 of https://codereview.chromium.org/2818623002/ ) Reason for revert: Likely cause of compilation error in Win x64. BUG=711316 Original issue's description: > When HttpNetworkTransaction encounters QUIC errors, retry the request > with alt-svc disabled, and if that succeeds then mark QUIC as broken. > > Protected by the retry_without_alt_svc_on_quic_errors finch param. > > BUG=705033 > > Review-Url: https://codereview.chromium.org/2818623002 > Cr-Commit-Position: refs/heads/master@{#464391} > Committed: https://chromium.googlesource.com/chromium/src/+/d0dbccf1f8d23dfa32defdd02c0a3df990729358 TBR=jri@chromium.org,ianswett@chromium.org,rch@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=705033 Review-Url: https://codereview.chromium.org/2811993005 Cr-Commit-Position: refs/heads/master@{#464403} Committed: https://chromium.googlesource.com/chromium/src/+/fab11cdbc638822aac069e23db9417d028e076a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -330 lines) Patch
M components/network_session_configurator/network_session_configurator.cc View 2 chunks +1 line, -10 lines 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/http/http_network_session.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_transaction.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/http/http_network_transaction.cc View 3 chunks +10 lines, -26 lines 0 comments Download
M net/quic/chromium/quic_network_transaction_unittest.cc View 3 chunks +0 lines, -274 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jdoerrie
Created Revert of When HttpNetworkTransaction encounters QUIC errors, retry the request
3 years, 8 months ago (2017-04-13 15:05:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811993005/1
3 years, 8 months ago (2017-04-13 15:06:34 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 15:08:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fab11cdbc638822aac069e23db94...

Powered by Google App Engine
This is Rietveld 408576698