Issue 2811813003: [Cronet] Move NetworkChangeNotifier initialization off UI thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2811813003: [Cronet] Move NetworkChangeNotifier initialization off UI thread (Closed)

Created:
3 years, 8 months ago by pauljensen

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org, agrieve+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Cronet] Move NetworkChangeNotifier initialization off UI thread Adapt NetworkChangeNotifierAutoDetector to live on either the UI thread or an internal thread. This facilitates moving initialization of the NetworkChangeNotifier off the UI thread. BUG=709336 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Patch Set 1 #

Patch Set 2 : add missing file #

Patch Set 3 : fix NPE #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -40 lines)			Patch
M	components/cronet/android/BUILD.gn	View		3 chunks	+4 lines, -0 lines	0 comments	Download
M	components/cronet/android/cronet_library_loader.cc	View		3 chunks	+2 lines, -6 lines	0 comments	Download
M	components/cronet/android/cronet_url_request_context_adapter.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java	View		2 chunks	+0 lines, -12 lines	0 comments	Download
A	components/cronet/android/java/src/org/chromium/net/impl/NetworkChangeNotifierIniter.java	View		1 chunk	+51 lines, -0 lines	0 comments	Download
A	components/cronet/android/network_change_notifier_initer.h	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
A	components/cronet/android/network_change_notifier_initer.cc	View		1 chunk	+33 lines, -0 lines	0 comments	Download
M	net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java	View	1 2	16 chunks	+60 lines, -22 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pauljensen

3 years, 8 months ago (2017-04-10 18:44:39 UTC) #1

Description was changed from

==========
[Cronet] Move NetworkChangeNotifier initialization off UI thread

Adapt NetworkChangeNotifierAutoDetector to live on either the UI thread
or an internal thread.  This facilitates moving initialization of the
NetworkChangeNotifier off the UI thread.

BUG=709336
==========

to

==========
[Cronet] Move NetworkChangeNotifier initialization off UI thread

Adapt NetworkChangeNotifierAutoDetector to live on either the UI thread
or an internal thread.  This facilitates moving initialization of the
NetworkChangeNotifier off the UI thread.

BUG=709336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages