Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: components/cronet/android/cronet_library_loader.cc

Issue 2811813003: [Cronet] Move NetworkChangeNotifier initialization off UI thread (Closed)
Patch Set: fix NPE Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/cronet/android/cronet_library_loader.h" 5 #include "components/cronet/android/cronet_library_loader.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/android/base_jni_onload.h" 10 #include "base/android/base_jni_onload.h"
11 #include "base/android/base_jni_registrar.h" 11 #include "base/android/base_jni_registrar.h"
12 #include "base/android/jni_android.h" 12 #include "base/android/jni_android.h"
13 #include "base/android/jni_registrar.h" 13 #include "base/android/jni_registrar.h"
14 #include "base/android/jni_utils.h" 14 #include "base/android/jni_utils.h"
15 #include "base/android/library_loader/library_loader_hooks.h" 15 #include "base/android/library_loader/library_loader_hooks.h"
16 #include "base/command_line.h" 16 #include "base/command_line.h"
17 #include "base/feature_list.h" 17 #include "base/feature_list.h"
18 #include "base/logging.h" 18 #include "base/logging.h"
19 #include "base/macros.h" 19 #include "base/macros.h"
20 #include "base/message_loop/message_loop.h" 20 #include "base/message_loop/message_loop.h"
21 #include "components/cronet/android/cronet_bidirectional_stream_adapter.h" 21 #include "components/cronet/android/cronet_bidirectional_stream_adapter.h"
22 #include "components/cronet/android/cronet_upload_data_stream_adapter.h" 22 #include "components/cronet/android/cronet_upload_data_stream_adapter.h"
23 #include "components/cronet/android/cronet_url_request_adapter.h" 23 #include "components/cronet/android/cronet_url_request_adapter.h"
24 #include "components/cronet/android/cronet_url_request_context_adapter.h" 24 #include "components/cronet/android/cronet_url_request_context_adapter.h"
25 #include "components/cronet/android/network_change_notifier_initer.h"
25 #include "components/cronet/version.h" 26 #include "components/cronet/version.h"
26 #include "jni/CronetLibraryLoader_jni.h" 27 #include "jni/CronetLibraryLoader_jni.h"
27 #include "net/android/net_jni_registrar.h" 28 #include "net/android/net_jni_registrar.h"
28 #include "net/android/network_change_notifier_factory_android.h" 29 #include "net/android/network_change_notifier_factory_android.h"
29 #include "net/base/network_change_notifier.h" 30 #include "net/base/network_change_notifier.h"
30 #include "url/url_features.h" 31 #include "url/url_features.h"
31 #include "url/url_util.h" 32 #include "url/url_util.h"
32 33
33 #if !BUILDFLAG(USE_PLATFORM_ICU_ALTERNATIVES) 34 #if !BUILDFLAG(USE_PLATFORM_ICU_ALTERNATIVES)
34 #include "base/i18n/icu_util.h" // nogncheck 35 #include "base/i18n/icu_util.h" // nogncheck
35 #endif 36 #endif
36 37
37 using base::android::JavaParamRef; 38 using base::android::JavaParamRef;
38 using base::android::ScopedJavaLocalRef; 39 using base::android::ScopedJavaLocalRef;
39 40
40 namespace cronet { 41 namespace cronet {
41 namespace { 42 namespace {
42 43
43 const base::android::RegistrationMethod kCronetRegisteredMethods[] = { 44 const base::android::RegistrationMethod kCronetRegisteredMethods[] = {
44 {"BaseAndroid", base::android::RegisterJni}, 45 {"BaseAndroid", base::android::RegisterJni},
45 {"CronetBidirectionalStreamAdapter", 46 {"CronetBidirectionalStreamAdapter",
46 CronetBidirectionalStreamAdapter::RegisterJni}, 47 CronetBidirectionalStreamAdapter::RegisterJni},
47 {"CronetLibraryLoader", RegisterNativesImpl}, 48 {"CronetLibraryLoader", RegisterNativesImpl},
48 {"CronetUploadDataStreamAdapter", CronetUploadDataStreamAdapterRegisterJni}, 49 {"CronetUploadDataStreamAdapter", CronetUploadDataStreamAdapterRegisterJni},
49 {"CronetUrlRequestAdapter", CronetUrlRequestAdapterRegisterJni}, 50 {"CronetUrlRequestAdapter", CronetUrlRequestAdapterRegisterJni},
50 {"CronetUrlRequestContextAdapter", 51 {"CronetUrlRequestContextAdapter",
51 CronetUrlRequestContextAdapterRegisterJni}, 52 CronetUrlRequestContextAdapterRegisterJni},
52 {"NetAndroid", net::android::RegisterJni}, 53 {"NetAndroid", net::android::RegisterJni},
54 {"NetworkChangeNotifierIniter", NetworkChangeNotifierIniterRegisterJni},
53 }; 55 };
54 56
55 // MessageLoop on the main thread, which is where objects that receive Java 57 // MessageLoop on the main thread, which is where objects that receive Java
56 // notifications generally live. 58 // notifications generally live.
57 base::MessageLoop* g_main_message_loop = nullptr; 59 base::MessageLoop* g_main_message_loop = nullptr;
58 60
59 net::NetworkChangeNotifier* g_network_change_notifier = nullptr;
60
61 bool RegisterJNI(JNIEnv* env) { 61 bool RegisterJNI(JNIEnv* env) {
62 return base::android::RegisterNativeMethods( 62 return base::android::RegisterNativeMethods(
63 env, kCronetRegisteredMethods, arraysize(kCronetRegisteredMethods)); 63 env, kCronetRegisteredMethods, arraysize(kCronetRegisteredMethods));
64 } 64 }
65 65
66 bool NativeInit() { 66 bool NativeInit() {
67 if (!base::android::OnJNIOnLoadInit()) 67 if (!base::android::OnJNIOnLoadInit())
68 return false; 68 return false;
69 url::Initialize(); 69 url::Initialize();
70 return true; 70 return true;
(...skipping 22 matching lines...) Expand all
93 #endif 93 #endif
94 94
95 base::FeatureList::InitializeInstance(std::string(), std::string()); 95 base::FeatureList::InitializeInstance(std::string(), std::string());
96 // TODO(bengr): Remove once Data Reduction Proxy no longer needs this for 96 // TODO(bengr): Remove once Data Reduction Proxy no longer needs this for
97 // configuration information. 97 // configuration information.
98 base::CommandLine::Init(0, nullptr); 98 base::CommandLine::Init(0, nullptr);
99 DCHECK(!base::MessageLoop::current()); 99 DCHECK(!base::MessageLoop::current());
100 DCHECK(!g_main_message_loop); 100 DCHECK(!g_main_message_loop);
101 g_main_message_loop = new base::MessageLoopForUI(); 101 g_main_message_loop = new base::MessageLoopForUI();
102 base::MessageLoopForUI::current()->Start(); 102 base::MessageLoopForUI::current()->Start();
103 DCHECK(!g_network_change_notifier);
104 net::NetworkChangeNotifier::SetFactory(
105 new net::NetworkChangeNotifierFactoryAndroid());
106 g_network_change_notifier = net::NetworkChangeNotifier::Create();
107 } 103 }
108 104
109 ScopedJavaLocalRef<jstring> GetCronetVersion( 105 ScopedJavaLocalRef<jstring> GetCronetVersion(
110 JNIEnv* env, 106 JNIEnv* env,
111 const JavaParamRef<jclass>& jcaller) { 107 const JavaParamRef<jclass>& jcaller) {
112 return base::android::ConvertUTF8ToJavaString(env, CRONET_VERSION); 108 return base::android::ConvertUTF8ToJavaString(env, CRONET_VERSION);
113 } 109 }
114 110
115 } // namespace cronet 111 } // namespace cronet
OLDNEW
« no previous file with comments | « components/cronet/android/BUILD.gn ('k') | components/cronet/android/cronet_url_request_context_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698