Fixes accessibility navigation out of autofill popup.

Fixes accessibility navigation out of Autofill popup.

We post a delayed callback to clear accessibility focus. If we receive a focus event, we cancel the delayed callback.

At the end of the video below, we can see the accessibility focus moving out of the popup and to the next HTML element, which is "Address:"

https://drive.google.com/a/google.com/file/d/0B-jTnU8uuAL9NzNUMGNzMXVYUUE/view?usp=sharing

BUG=627860
Review-Url: https://codereview.chromium.org/2811803002
Cr-Commit-Position: refs/heads/master@{#464088}
Committed: https://chromium.googlesource.com/chromium/src/+/4b16553ab1201a9830dc46e01892f9ea21eb3ef9

[csashi, 2017-04-10 17:27:57]

The CQ bit was checked by csashi@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 17:28:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[csashi, 2017-04-10 17:30:10]

Description was changed from

==========
Fixes accessibility navigation out of autofill popup.

BUG=627860
==========

to

==========
Fixes accessibility navigation out of Autofill popup.

We post a delayed callback to clear accessibility focus. If we receive a focus
event, we cancel the delayed callback.

At the end of the video below, we can see the accessibility focus moving out of
the popup and to the next HTML element, which is "Address:"

https://drive.google.com/a/google.com/file/d/0B-jTnU8uuAL9NzNUMGNzMXVYUUE/vie...

BUG=627860
==========

[csashi, 2017-04-10 17:30:10]

csashi@google.com changed reviewers:
+ dmazzoni@chromium.org, mathp@chromium.org

[csashi, 2017-04-10 17:31:26]

Hi,
Please take a look. Thanks!
-sashi.

[dmazzoni, 2017-04-10 17:39:06]

lgtm

https://codereview.chromium.org/2811803002/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility_manager_android.cc
(right):

https://codereview.chromium.org/2811803002/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_manager_android.cc:1017:
return g_element_after_element_hosting_autofill_popup_unique_id;
It's possible that the user navigated away.

You should probably check to make sure that this node exists still,
and return 0 otherwise.

https://codereview.chromium.org/2811803002/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility_manager_android.h
(right):

https://codereview.chromium.org/2811803002/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_manager_android.h:233: jint
OnAutofillPopupAccessibilityFocusCleared(
Document what this returns. It'd be even better to name this method
something that makes it clear what it returns, or else split it into two
methods, one that does something and one that returns the id of the
next element.

[commit-bot: I haz the power, 2017-04-10 17:52:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 17:52:17]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[csashi, 2017-04-10 18:06:27]

csashi@google.com changed reviewers:
+ sgurun@chromium.org

[csashi, 2017-04-10 18:06:28]

Hi Selim,
Can you please approve for android_webview? Thanks,
-sashi.

https://codereview.chromium.org/2811803002/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility_manager_android.cc
(right):

https://codereview.chromium.org/2811803002/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_manager_android.cc:1017:
return g_element_after_element_hosting_autofill_popup_unique_id;
On 2017/04/10 17:39:06, dmazzoni wrote:
> It's possible that the user navigated away.
> 
> You should probably check to make sure that this node exists still,
> and return 0 otherwise.

Done.

https://codereview.chromium.org/2811803002/diff/1/content/browser/accessibili...
File content/browser/accessibility/browser_accessibility_manager_android.h
(right):

https://codereview.chromium.org/2811803002/diff/1/content/browser/accessibili...
content/browser/accessibility/browser_accessibility_manager_android.h:233: jint
OnAutofillPopupAccessibilityFocusCleared(
On 2017/04/10 17:39:06, dmazzoni wrote:
> Document what this returns. It'd be even better to name this method
> something that makes it clear what it returns, or else split it into two
> methods, one that does something and one that returns the id of the
> next element.
> 

Done. I hope the new name make it clear what this returns?

[csashi, 2017-04-10 18:07:03]

The CQ bit was checked by csashi@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 18:07:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sgurun-gerrit only, 2017-04-10 18:11:18]

lgtm

[commit-bot: I haz the power, 2017-04-10 18:40:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 18:40:49]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[csashi, 2017-04-10 18:48:24]

csashi@google.com changed reviewers:
+ dtrainor@chromium.org

[csashi, 2017-04-10 18:48:25]

Hi David,
Please approve
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java
Thanks,
-sashi.

[csashi, 2017-04-10 18:48:38]

The CQ bit was checked by csashi@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 18:49:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 19:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:56:28]

Dry run: This issue passed the CQ dry run.

[csashi, 2017-04-12 00:34:33]

On 2017/04/10 18:48:25, csashi wrote:
> Hi David,
> Please approve
>
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java
> Thanks,
> -sashi.

Hi David,
Can you approve for
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java?
Hi Mathieu,
Can you approve for chrome/android/java/src/org/chromium/chrome/browser/autofill
?

Thanks,
-sashi.

[David Trainor- moved to gerrit, 2017-04-12 16:13:19]

chrome/android/javatests lgtm

[csashi, 2017-04-12 16:19:21]

On 2017/04/12 00:34:33, csashi wrote:
> On 2017/04/10 18:48:25, csashi wrote:
> > Hi David,
> > Please approve
> >
>
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java
> > Thanks,
> > -sashi.
> 
> Hi David,
> Can you approve for
>
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java?
> Hi Mathieu,
> Can you approve for
chrome/android/java/src/org/chromium/chrome/browser/autofill
> ?
> 
> Thanks,
> -sashi.

Hi Mathieu,
Sorry. I need your approval for
components/autofill/android/java/src/org/chromium/components/autofill.
Thanks,
-sashi.

[Mathieu, 2017-04-12 16:51:20]

lgtm

[csashi, 2017-04-12 17:14:45]

The CQ bit was checked by csashi@google.com

[csashi, 2017-04-12 17:14:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org, sgurun@chromium.org
Link to the patchset: https://codereview.chromium.org/2811803002/#ps40001
(title: "Renames OnAutofillPopupAccessibilityFocusCleared to
GetIdForElementAfterElementHostingAutofillPopup.")

[commit-bot: I haz the power, 2017-04-12 17:15:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 18:12:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492017285761510,
"parent_rev": "2d54317a97881484713af4069f01677e924dc87e", "commit_rev":
"4b16553ab1201a9830dc46e01892f9ea21eb3ef9"}

[commit-bot: I haz the power, 2017-04-12 18:13:49]

Description was changed from

==========
Fixes accessibility navigation out of Autofill popup.

We post a delayed callback to clear accessibility focus. If we receive a focus
event, we cancel the delayed callback.

At the end of the video below, we can see the accessibility focus moving out of
the popup and to the next HTML element, which is "Address:"

https://drive.google.com/a/google.com/file/d/0B-jTnU8uuAL9NzNUMGNzMXVYUUE/vie...

BUG=627860
==========

to

==========
Fixes accessibility navigation out of Autofill popup.

We post a delayed callback to clear accessibility focus. If we receive a focus
event, we cancel the delayed callback.

At the end of the video below, we can see the accessibility focus moving out of
the popup and to the next HTML element, which is "Address:"

https://drive.google.com/a/google.com/file/d/0B-jTnU8uuAL9NzNUMGNzMXVYUUE/vie...

BUG=627860

Review-Url: https://codereview.chromium.org/2811803002
Cr-Commit-Position: refs/heads/master@{#464088}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b16553ab1201a9830dc46e01892...
==========

[commit-bot: I haz the power, 2017-04-12 18:13:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4b16553ab1201a9830dc46e01892...