Chromium Code Reviews Chromium Code Reviews
Issue
2811733003:
Revert "Make transport security state generation part of the build." (Closed)
DescriptionRevert "Make transport security state generation part of the build."
This reverts commit 6ee4f021659260c12c361bb78eb211c9ba69e8bf.
Reason for revert:
This breaks Chrome PFQ with error:
chromeos-chrome-59.0.3067.0_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/binutils/Linux_x64/Release/bin/ld.gold: error: cannot find -latomic
Original change's description:
> Make transport security state generation part of the build.
>
> This CL adds a build step to generate transport_security_state_static.h
> when required.
>
> Bug:595493
>
> Change-Id: I478137a40d9107cbcc6470ee544bda66823ebbff
> Reviewed-on: https://chromium-review.googlesource.com/471529
> Reviewed-by: Lucas Garron <lgarron@chromium.org>;
> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>;
> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>;
> Cr-Commit-Position: refs/heads/master@{#463090}
TBR=rsleevi@chromium.org,peter@chromium.org,lgarron@chromium.org,martijn@martijnc.be,cbentzel+watch@chromium.org,net-reviews@chromium.org
BUG=710006
[added to Rietveld description by lgarron]
Change-Id: I84536c89c093531f1cf60cbdd4a3cfb2efbe5d80
Reviewed-on: https://chromium-review.googlesource.com/474009
Reviewed-by: Yury Khmel <khmel@chromium.org>;
Cr-Original-Commit-Position: refs/heads/master@{#463428}(cherry picked from commit 5e671fffc45441c5dd3458871a8aa8f4a3f2e632)
Review-Url: https://codereview.chromium.org/2811733003 .
Cr-Commit-Position: refs/branch-heads/3067@{#4}
Cr-Branched-From: e2ed4b4539b7a50d8be892e4437897b18c181c91-refs/heads/master@{#463157}
Committed: https://chromium.googlesource.com/chromium/src/+/efa139d3af68589d5b803a8a322f41d83e56af06
Patch Set 1 #
Created: 3 years, 8 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (2 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
