Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2811713006: Fire event on Mac when PRESSED state changes (Closed)

Created:
3 years, 8 months ago by dmazzoni
Modified:
3 years, 8 months ago
Reviewers:
nektarios
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, mac-reviews_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fire event on Mac when PRESSED state changes On Mac, toggle buttons are subclasses of checkboxes, so we can handle them the same as when a checkbox changes. This is a great use of the new attribute chance callback infrastructure. BUG=709572, 699438 Review-Url: https://codereview.chromium.org/2811713006 Cr-Commit-Position: refs/heads/master@{#463647} Committed: https://chromium.googlesource.com/chromium/src/+/dd5b263792257e226f31136b15af0341673811d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M content/browser/accessibility/browser_accessibility_manager_mac.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.mm View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dmazzoni
3 years, 8 months ago (2017-04-11 05:33:25 UTC) #3
Dan Beam
i can't really speak to the methodology of the code change, but this definitely fixes ...
3 years, 8 months ago (2017-04-11 06:09:17 UTC) #7
nektarios
lgtm
3 years, 8 months ago (2017-04-11 15:54:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811713006/1
3 years, 8 months ago (2017-04-11 16:04:35 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 16:16:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dd5b263792257e226f31136b15af...

Powered by Google App Engine
This is Rietveld 408576698