Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Issue 2811693005: Handle pixel (un)pack buffers with non-zero offset. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
index d602360c369fbf5981ce8050b6f0eeb0b74b56a8..c00d2cb52fb7be698776856d64529414c52225fa 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
@@ -467,7 +467,10 @@ error::Error GLES2DecoderPassthroughImpl::DoCompressedTexImage2D(
GLsizei height,
GLint border,
GLsizei imageSize,
+ GLsizei dataSize,
Zhenyao Mo 2017/04/11 19:56:54 nit: this is actually against chromium coding styl
Corentin Wallez 2017/04/11 22:06:34 Done here and in other places in this file and the
const void* data) {
+ // TODO(cwallez@chromium.org): Use dataSize with the robust version of the
+ // entry point
glCompressedTexImage2D(target, level, internalformat, width, height, border,
imageSize, data);
return error::kNoError;
@@ -482,7 +485,10 @@ error::Error GLES2DecoderPassthroughImpl::DoCompressedTexSubImage2D(
GLsizei height,
GLenum format,
GLsizei imageSize,
+ GLsizei dataSize,
const void* data) {
+ // TODO(cwallez@chromium.org): Use dataSize with the robust version of the
+ // entry point
glCompressedTexSubImage2D(target, level, xoffset, yoffset, width, height,
format, imageSize, data);
return error::kNoError;
@@ -497,7 +503,10 @@ error::Error GLES2DecoderPassthroughImpl::DoCompressedTexImage3D(
GLsizei depth,
GLint border,
GLsizei imageSize,
+ GLsizei dataSize,
const void* data) {
+ // TODO(cwallez@chromium.org): Use dataSize with the robust version of the
+ // entry point
glCompressedTexImage3D(target, level, internalformat, width, height, depth,
border, imageSize, data);
return error::kNoError;
@@ -514,7 +523,10 @@ error::Error GLES2DecoderPassthroughImpl::DoCompressedTexSubImage3D(
GLsizei depth,
GLenum format,
GLsizei imageSize,
+ GLsizei dataSize,
const void* data) {
+ // TODO(cwallez@chromium.org): Use dataSize with the robust version of the
+ // entry point
glCompressedTexSubImage3D(target, level, xoffset, yoffset, zoffset, width,
height, depth, format, imageSize, data);
return error::kNoError;

Powered by Google App Engine
This is Rietveld 408576698