Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Side by Side Diff: gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Issue 2811693005: Handle pixel (un)pack buffers with non-zero offset. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h" 5 #include "gpu/command_buffer/service/gles2_cmd_decoder_passthrough.h"
6 6
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 #include "ui/gl/gl_version_info.h" 8 #include "ui/gl/gl_version_info.h"
9 9
10 namespace gpu { 10 namespace gpu {
(...skipping 449 matching lines...) Expand 10 before | Expand all | Expand 10 after
460 } 460 }
461 461
462 error::Error GLES2DecoderPassthroughImpl::DoCompressedTexImage2D( 462 error::Error GLES2DecoderPassthroughImpl::DoCompressedTexImage2D(
463 GLenum target, 463 GLenum target,
464 GLint level, 464 GLint level,
465 GLenum internalformat, 465 GLenum internalformat,
466 GLsizei width, 466 GLsizei width,
467 GLsizei height, 467 GLsizei height,
468 GLint border, 468 GLint border,
469 GLsizei imageSize, 469 GLsizei imageSize,
470 GLsizei dataSize,
Zhenyao Mo 2017/04/11 19:56:54 nit: this is actually against chromium coding styl
Corentin Wallez 2017/04/11 22:06:34 Done here and in other places in this file and the
470 const void* data) { 471 const void* data) {
472 // TODO(cwallez@chromium.org): Use dataSize with the robust version of the
473 // entry point
471 glCompressedTexImage2D(target, level, internalformat, width, height, border, 474 glCompressedTexImage2D(target, level, internalformat, width, height, border,
472 imageSize, data); 475 imageSize, data);
473 return error::kNoError; 476 return error::kNoError;
474 } 477 }
475 478
476 error::Error GLES2DecoderPassthroughImpl::DoCompressedTexSubImage2D( 479 error::Error GLES2DecoderPassthroughImpl::DoCompressedTexSubImage2D(
477 GLenum target, 480 GLenum target,
478 GLint level, 481 GLint level,
479 GLint xoffset, 482 GLint xoffset,
480 GLint yoffset, 483 GLint yoffset,
481 GLsizei width, 484 GLsizei width,
482 GLsizei height, 485 GLsizei height,
483 GLenum format, 486 GLenum format,
484 GLsizei imageSize, 487 GLsizei imageSize,
488 GLsizei dataSize,
485 const void* data) { 489 const void* data) {
490 // TODO(cwallez@chromium.org): Use dataSize with the robust version of the
491 // entry point
486 glCompressedTexSubImage2D(target, level, xoffset, yoffset, width, height, 492 glCompressedTexSubImage2D(target, level, xoffset, yoffset, width, height,
487 format, imageSize, data); 493 format, imageSize, data);
488 return error::kNoError; 494 return error::kNoError;
489 } 495 }
490 496
491 error::Error GLES2DecoderPassthroughImpl::DoCompressedTexImage3D( 497 error::Error GLES2DecoderPassthroughImpl::DoCompressedTexImage3D(
492 GLenum target, 498 GLenum target,
493 GLint level, 499 GLint level,
494 GLenum internalformat, 500 GLenum internalformat,
495 GLsizei width, 501 GLsizei width,
496 GLsizei height, 502 GLsizei height,
497 GLsizei depth, 503 GLsizei depth,
498 GLint border, 504 GLint border,
499 GLsizei imageSize, 505 GLsizei imageSize,
506 GLsizei dataSize,
500 const void* data) { 507 const void* data) {
508 // TODO(cwallez@chromium.org): Use dataSize with the robust version of the
509 // entry point
501 glCompressedTexImage3D(target, level, internalformat, width, height, depth, 510 glCompressedTexImage3D(target, level, internalformat, width, height, depth,
502 border, imageSize, data); 511 border, imageSize, data);
503 return error::kNoError; 512 return error::kNoError;
504 } 513 }
505 514
506 error::Error GLES2DecoderPassthroughImpl::DoCompressedTexSubImage3D( 515 error::Error GLES2DecoderPassthroughImpl::DoCompressedTexSubImage3D(
507 GLenum target, 516 GLenum target,
508 GLint level, 517 GLint level,
509 GLint xoffset, 518 GLint xoffset,
510 GLint yoffset, 519 GLint yoffset,
511 GLint zoffset, 520 GLint zoffset,
512 GLsizei width, 521 GLsizei width,
513 GLsizei height, 522 GLsizei height,
514 GLsizei depth, 523 GLsizei depth,
515 GLenum format, 524 GLenum format,
516 GLsizei imageSize, 525 GLsizei imageSize,
526 GLsizei dataSize,
517 const void* data) { 527 const void* data) {
528 // TODO(cwallez@chromium.org): Use dataSize with the robust version of the
529 // entry point
518 glCompressedTexSubImage3D(target, level, xoffset, yoffset, zoffset, width, 530 glCompressedTexSubImage3D(target, level, xoffset, yoffset, zoffset, width,
519 height, depth, format, imageSize, data); 531 height, depth, format, imageSize, data);
520 return error::kNoError; 532 return error::kNoError;
521 } 533 }
522 534
523 error::Error GLES2DecoderPassthroughImpl::DoCopyBufferSubData( 535 error::Error GLES2DecoderPassthroughImpl::DoCopyBufferSubData(
524 GLenum readtarget, 536 GLenum readtarget,
525 GLenum writetarget, 537 GLenum writetarget,
526 GLintptr readoffset, 538 GLintptr readoffset,
527 GLintptr writeoffset, 539 GLintptr writeoffset,
(...skipping 3441 matching lines...) Expand 10 before | Expand all | Expand 10 after
3969 } 3981 }
3970 3982
3971 error::Error GLES2DecoderPassthroughImpl::DoSetEnableDCLayersCHROMIUM( 3983 error::Error GLES2DecoderPassthroughImpl::DoSetEnableDCLayersCHROMIUM(
3972 GLboolean enable) { 3984 GLboolean enable) {
3973 NOTIMPLEMENTED(); 3985 NOTIMPLEMENTED();
3974 return error::kNoError; 3986 return error::kNoError;
3975 } 3987 }
3976 3988
3977 } // namespace gles2 3989 } // namespace gles2
3978 } // namespace gpu 3990 } // namespace gpu
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698