Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: chrome/browser/extensions/webstore_inline_installer_unittest.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Workaround with std::move Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_inline_installer_unittest.cc
diff --git a/chrome/browser/extensions/webstore_inline_installer_unittest.cc b/chrome/browser/extensions/webstore_inline_installer_unittest.cc
index 961e77a7b80a90bcb9b5293db70860f46553be97..c4262e62b1b470d04363dd96fa21f9be6b00d024 100644
--- a/chrome/browser/extensions/webstore_inline_installer_unittest.cc
+++ b/chrome/browser/extensions/webstore_inline_installer_unittest.cc
@@ -2,8 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <utility>
#include <vector>
+#include "base/memory/ptr_util.h"
#include "chrome/browser/extensions/webstore_inline_installer.h"
#include "chrome/common/extensions/webstore_install_result.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
@@ -95,13 +97,13 @@ bool WebstoreInlineInstallerTest::TestSingleVerifiedSite(
bool WebstoreInlineInstallerTest::TestMultipleVerifiedSites(
const std::string& requestor_url,
const std::vector<std::string>& verified_sites) {
- base::ListValue* sites = new base::ListValue();
+ auto sites = base::MakeUnique<base::ListValue>();
for (std::vector<std::string>::const_iterator it = verified_sites.begin();
it != verified_sites.end(); ++it) {
sites->AppendString(*it);
}
base::DictionaryValue webstore_data;
- webstore_data.Set("verified_sites", sites);
+ webstore_data.Set("verified_sites", std::move(sites));
scoped_refptr<TestWebstoreInlineInstaller> installer =
new TestWebstoreInlineInstaller(web_contents_.get(), requestor_url);

Powered by Google App Engine
This is Rietveld 408576698