chrome/browser/extensions/permissions_based_management_policy_provider_unittest.cc - Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/permissions_based_management_policy_provider_unittest.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Workaround with std::move Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/menu_manager_unittest.cc ('k') | chrome/browser/extensions/webstore_inline_installer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/permissions_based_management_policy_provider_unittest.cc

diff --git a/chrome/browser/extensions/permissions_based_management_policy_provider_unittest.cc b/chrome/browser/extensions/permissions_based_management_policy_provider_unittest.cc

index 41e308c41f5c98894f014aa14271d9db065a36f2..806d14f0fda983c01083b918129a3e5ad4646da3 100644

--- a/chrome/browser/extensions/permissions_based_management_policy_provider_unittest.cc

+++ b/chrome/browser/extensions/permissions_based_management_policy_provider_unittest.cc

@@ -65,11 +65,11 @@ class PermissionsBasedManagementPolicyProviderTest : public testing::Test {

manifest_dict.SetString(manifest_keys::kVersion, "0.1");

if (required_permissions) {

manifest_dict.Set(manifest_keys::kPermissions,

- required_permissions->DeepCopy());

+ required_permissions->CreateDeepCopy());

}

if (optional_permissions) {

manifest_dict.Set(manifest_keys::kOptionalPermissions,

- optional_permissions->DeepCopy());

+ optional_permissions->CreateDeepCopy());

}

std::string error;

scoped_refptr<const Extension> extension = Extension::Create(