Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)
Patch Set: Workaround with std::move Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
diff --git a/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc b/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
index 8955c29f1d4b45f59b14bd87829646ff43af7286..9984780697852ce7ea656830491c8d7a22b609a2 100644
--- a/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
+++ b/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
@@ -585,7 +585,7 @@ void MediaGalleriesAddUserSelectedFolderFunction::ReturnGalleriesAndId(
}
}
std::unique_ptr<base::DictionaryValue> results(new base::DictionaryValue);
- results->SetWithoutPathExpansion("mediaFileSystems", list.release());
+ results->SetWithoutPathExpansion("mediaFileSystems", std::move(list));
results->SetIntegerWithoutPathExpansion("selectedFileSystemIndex", index);
SetResult(std::move(results));
SendResponse(true);

Powered by Google App Engine
This is Rietveld 408576698