chrome/browser/extensions/api/messaging/native_messaging_test_util.cc - Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_messaging_test_util.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Workaround with std::move Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/media_galleries/media_galleries_api.cc ('k') | chrome/browser/extensions/api/omnibox/omnibox_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_messaging_test_util.cc

diff --git a/chrome/browser/extensions/api/messaging/native_messaging_test_util.cc b/chrome/browser/extensions/api/messaging/native_messaging_test_util.cc

index 783b0b656b0b7558ede34d1bf66e2455ea50f42a..ebd91a7b10b56cdeb395db284e00c5d9eb4f126d 100644

--- a/chrome/browser/extensions/api/messaging/native_messaging_test_util.cc

+++ b/chrome/browser/extensions/api/messaging/native_messaging_test_util.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/extensions/api/messaging/native_messaging_test_util.h"

#include <memory>

+#include <utility>

#include "base/files/file_path.h"

#include "base/json/json_file_value_serializer.h"

@@ -37,7 +38,7 @@ void WriteTestNativeHostManifest(const base::FilePath& target_dir,

std::unique_ptr<base::ListValue> origins(new base::ListValue());

origins->AppendString(base::StringPrintf(

"chrome-extension://%s/", ScopedTestNativeMessagingHost::kExtensionId));

- manifest->Set("allowed_origins", origins.release());

+ manifest->Set("allowed_origins", std::move(origins));

base::FilePath manifest_path = target_dir.AppendASCII(host_name + ".json");

JSONFileValueSerializer serializer(manifest_path);