chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc - Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Workaround with std::move Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc ('k') | chrome/browser/extensions/api/mdns/mdns_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

diff --git a/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc b/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

index 1a12db9901ff136022bc6821ea0a5732cd905b0a..822e9ff45c04792981eed2f643b36616f61cc889 100644

--- a/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

+++ b/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

@@ -15,6 +15,7 @@

#include "base/lazy_instance.h"

#include "base/logging.h"

#include "base/memory/ptr_util.h"

+#include "base/values.h"

#include "build/build_config.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/download/download_prefs.h"

@@ -543,9 +544,9 @@ void LogPrivateDumpLogsFunction::OnStoreLogsCompleted(

entry->SetString("baseName", file_entry.registered_name);

entry->SetString("id", file_entry.id);

entry->SetBoolean("isDirectory", false);

- base::ListValue* entry_list = new base::ListValue();

+ auto entry_list = base::MakeUnique<base::ListValue>();

entry_list->Append(std::move(entry));

- response->Set("entries", entry_list);

+ response->Set("entries", std::move(entry_list));

response->SetBoolean("multiple", false);

SetResult(std::move(response));

SendResponse(succeeded);