chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc - Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Workaround with std::move Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/font_settings/font_settings_api.cc ('k') | chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc

diff --git a/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc b/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc

index ebb5cb997b993c014f85e33e66796486228ebb57..4180966a5bb9b70acfddb19b65876e345f494a4e 100644

--- a/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc

+++ b/chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc

@@ -12,6 +12,8 @@

#include "base/command_line.h"

#include "base/macros.h"

+#include "base/memory/ptr_util.h"

+#include "base/values.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/browser_window.h"

@@ -378,7 +380,7 @@ ExtensionFunction::ResponseAction InputImeCreateWindowFunction::Run() {

return RespondNow(Error(error));

std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());

- result->Set("frameId", new base::Value(frame_id));

+ result->Set("frameId", base::MakeUnique<base::Value>(frame_id));

return RespondNow(OneArgument(std::move(result)));

}