chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc - Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Workaround with std::move Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc ('k') | chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc

diff --git a/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc b/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc

index 0bf377dc62ed259b1ef14b2a105e8a72e22b3165..fb2514d3efb0aeee8d89b3628514b013c0e2af22 100644

--- a/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc

+++ b/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc

@@ -552,7 +552,7 @@ void UserImageManagerImpl::Job::UpdateLocalState() {

base::MakeUnique<base::Value>(image_url_.spec()));

DictionaryPrefUpdate update(g_browser_process->local_state(),

kUserImageProperties);

- update->SetWithoutPathExpansion(user_id(), entry.release());

+ update->SetWithoutPathExpansion(user_id(), std::move(entry));

parent_->user_manager_->NotifyLocalStateChanged();

}