chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc - Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Workaround with std::move Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/registry_unittest.cc ('k') | chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

diff --git a/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc b/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

index f90c820bb3e85729d3a22ae1e1c17218e3e4c108..4399cbc33f173a36dd2ba34a9d2b277c8094d83b 100644

--- a/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

+++ b/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc

@@ -178,11 +178,11 @@ void SupervisedUserAuthentication::StorePasswordData(

owner_->GetPasswordInformation(user_id, &holder);

const base::Value* value;

if (password_data.GetWithoutPathExpansion(kSchemaVersion, &value))

- holder.SetWithoutPathExpansion(kSchemaVersion, value->DeepCopy());

+ holder.SetWithoutPathExpansion(kSchemaVersion, value->CreateDeepCopy());

if (password_data.GetWithoutPathExpansion(kSalt, &value))

- holder.SetWithoutPathExpansion(kSalt, value->DeepCopy());

+ holder.SetWithoutPathExpansion(kSalt, value->CreateDeepCopy());

if (password_data.GetWithoutPathExpansion(kPasswordRevision, &value))

- holder.SetWithoutPathExpansion(kPasswordRevision, value->DeepCopy());

+ holder.SetWithoutPathExpansion(kPasswordRevision, value->CreateDeepCopy());

owner_->SetPasswordInformation(user_id, &holder);

}