chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc - Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Workaround with std::move Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc ('k') | chrome/browser/chromeos/file_system_provider/registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc

diff --git a/chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc b/chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc

index 3724b0137558f239a3e5b73c07ed9e208f3613ad..8dc71f1e9a124666fed26ad9d4419ea5928a256a 100644

--- a/chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc

+++ b/chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc

@@ -83,9 +83,10 @@ class FakeEventRouter : public extensions::EventRouter {

if (reply_result_ == base::File::FILE_OK) {

base::ListValue value_as_list;

- value_as_list.Set(0, new base::Value(kFileSystemId));

- value_as_list.Set(1, new base::Value(request_id));

- value_as_list.Set(2, new base::Value(0) /* execution_time */);

+ value_as_list.Set(0, base::MakeUnique<base::Value>(kFileSystemId));

+ value_as_list.Set(1, base::MakeUnique<base::Value>(request_id));

+ value_as_list.Set(2,

+ base::MakeUnique<base::Value>(0) /* execution_time */);

using extensions::api::file_system_provider_internal::

OperationRequestedSuccess::Params;