chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc - Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc

Issue 2811673002: Reland: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Workaround with std::move Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/file_manager/url_util.cc ('k') | chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc

diff --git a/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc b/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc

index 18fd5f611b8b91b38130251cf02f22ba87fa4054..32bfabcef70884e60e586d5d71bb3722a123b825 100644

--- a/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc

+++ b/chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc

@@ -175,12 +175,12 @@ TEST_F(FileSystemProviderOperationsReadFileTest, OnSuccess) {

const int execution_time = 0;

base::ListValue value_as_list;

- value_as_list.Set(0, new base::Value(kFileSystemId));

- value_as_list.Set(1, new base::Value(kRequestId));

+ value_as_list.Set(0, base::MakeUnique<base::Value>(kFileSystemId));

+ value_as_list.Set(1, base::MakeUnique<base::Value>(kRequestId));

value_as_list.Set(

2, base::BinaryValue::CreateWithCopiedBuffer(data.c_str(), data.size()));

- value_as_list.Set(3, new base::Value(has_more));

- value_as_list.Set(4, new base::Value(execution_time));

+ value_as_list.Set(3, base::MakeUnique<base::Value>(has_more));

+ value_as_list.Set(4, base::MakeUnique<base::Value>(execution_time));

std::unique_ptr<Params> params(Params::Create(value_as_list));

ASSERT_TRUE(params.get());