Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2811643005: Fix the Learn More link for Printing in CrOS. (Closed)

Created:
3 years, 8 months ago by skau
Modified:
3 years, 8 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, xdai1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the Learn More link for Printing in CrOS. Update the link from a chrome:// link to the appropriate support article. BUG=710244 Review-Url: https://codereview.chromium.org/2811643005 Cr-Commit-Position: refs/heads/master@{#463788} Committed: https://chromium.googlesource.com/chromium/src/+/b5fc588fa5b37b9d879a7edaedb9702ff9a18db1

Patch Set 1 #

Patch Set 2 : fix learn more link for Printing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/url_constants.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
skau
Please take a look. The attached bug has more information.
3 years, 8 months ago (2017-04-10 22:54:29 UTC) #2
stevenjb
lgtm
3 years, 8 months ago (2017-04-11 19:53:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811643005/20001
3 years, 8 months ago (2017-04-11 21:43:53 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 21:55:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b5fc588fa5b37b9d879a7edaedb9...

Powered by Google App Engine
This is Rietveld 408576698