Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2811643003: chromeos: Cleanup comments and DEPS in //ash (Closed)

Created:
3 years, 8 months ago by James Cook
Modified:
3 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Cleanup comments and DEPS in //ash Remove references to //ash/common, rewrite the top-level README.md, and remove unnecessary DEPS. BUG=none TEST=checkdeps passes Review-Url: https://codereview.chromium.org/2811643003 Cr-Commit-Position: refs/heads/master@{#463301} Committed: https://chromium.googlesource.com/chromium/src/+/a6a6e611adeab2c8dd64a4229743c61a3c1c7a22

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -21 lines) Patch
M ash/README.md View 1 1 chunk +38 lines, -6 lines 0 comments Download
M ash/accelerators/accelerator_controller_delegate_aura.h View 1 chunk +4 lines, -3 lines 0 comments Download
M ash/mus/DEPS View 1 chunk +1 line, -9 lines 0 comments Download
M ash/test/ash_test.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_keyboard_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
James Cook
sky, please take a look.
3 years, 8 months ago (2017-04-10 16:09:36 UTC) #4
sky
LGTM https://codereview.chromium.org/2811643003/diff/1/ash/README.md File ash/README.md (right): https://codereview.chromium.org/2811643003/diff/1/ash/README.md#newcode34 ash/README.md:34: --mash command line flag. optional: you might also ...
3 years, 8 months ago (2017-04-10 16:21:20 UTC) #5
James Cook
Thanks for the quick review. https://codereview.chromium.org/2811643003/diff/1/ash/README.md File ash/README.md (right): https://codereview.chromium.org/2811643003/diff/1/ash/README.md#newcode34 ash/README.md:34: --mash command line flag. ...
3 years, 8 months ago (2017-04-10 16:40:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811643003/20001
3 years, 8 months ago (2017-04-10 16:41:02 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 17:15:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a6a6e611adeab2c8dd64a4229743...

Powered by Google App Engine
This is Rietveld 408576698