Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 2811633002: Include headless resources in Mac OS (Closed)

Created:
3 years, 8 months ago by dvallet
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Include headless resources in Mac OS Headless is enable in Mac and Linux, and will soon be enabled in Windows. This patch adds headless resources (1.7 Kb) to all those versions Launch bug: http://crbug.com/705916 BUG=709836 Review-Url: https://codereview.chromium.org/2811633002 Cr-Commit-Position: refs/heads/master@{#464299} Committed: https://chromium.googlesource.com/chromium/src/+/7333f8119912a21c35d48e14503f26ad45f43763

Patch Set 1 #

Patch Set 2 : Add resources only for mac and linux for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/chrome_paks.gni View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
dvallet
3 years, 8 months ago (2017-04-10 07:15:03 UTC) #2
Sami
lgtm
3 years, 8 months ago (2017-04-10 10:24:17 UTC) #7
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-10 12:51:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811633002/1
3 years, 8 months ago (2017-04-10 22:42:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/204775)
3 years, 8 months ago (2017-04-11 00:25:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811633002/20001
3 years, 8 months ago (2017-04-13 03:03:14 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 04:49:43 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7333f8119912a21c35d48e14503f...

Powered by Google App Engine
This is Rietveld 408576698