Fetch API: Add Request#cache attribute

third_party/WebKit/Source/modules/fetch/FetchRequestData.h

Index: third_party/WebKit/Source/modules/fetch/FetchRequestData.h
diff --git a/third_party/WebKit/Source/modules/fetch/FetchRequestData.h b/third_party/WebKit/Source/modules/fetch/FetchRequestData.h
index d96b33537a60442d7cb4f889f1b9367b08f23032..a46c35723a912579f86f14f4f179232d0e992468 100644
--- a/third_party/WebKit/Source/modules/fetch/FetchRequestData.h
+++ b/third_party/WebKit/Source/modules/fetch/FetchRequestData.h
@@ -66,6 +66,8 @@ class FetchRequestData final
   WebURLRequest::FetchCredentialsMode Credentials() const {
     return credentials_;
   }

[falken, 2017/04/11 05:53:59]

SetCache() and Cache() are quite generic names, but I guess it's ok if it's
obvious that FetchRequestData represents the Fetch API's Request interface.

I slightly prefer changing these to SetCacheMode() and and CacheMode() as it's
clearer to read, although it's not exactly the same as the Request interface's
|cache| attribute. However, I'm not an OWNER of this file, so you can wait for
yhirano's input.

Question for yhirano: Is it obvious that FetchRequestData represents the DOM
Request interface? Should this have a class-level comment?

[yhirano, 2017/04/11 06:26:51]

[Set]CacheMode sounds better to me, too.

[yiyix, 2017/04/11 10:00:06]

Done.

+  void SetCache(WebURLRequest::FetchRequestCache cache) { cache_ = cache; }
+  WebURLRequest::FetchRequestCache Cache() const { return cache_; }
   void SetRedirect(WebURLRequest::FetchRedirectMode redirect) {
     redirect_ = redirect;
   }
@@ -120,6 +122,7 @@ class FetchRequestData final
   // FIXME: Support m_synchronousFlag;
   WebURLRequest::FetchRequestMode mode_;
   WebURLRequest::FetchCredentialsMode credentials_;
+  WebURLRequest::FetchRequestCache cache_;
   WebURLRequest::FetchRedirectMode redirect_;
   // FIXME: Support m_useURLCredentialsFlag;
   // FIXME: Support m_redirectCount;