Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2811593007: [devtools] Add test for transparent background color override. (Closed)

Created:
3 years, 8 months ago by Eric Seckler
Modified:
3 years, 8 months ago
Reviewers:
dgozman, Sami
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, Sami
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[devtools] Add test for transparent background color override. Added a test, now that blink now supports transparent overrides correctly. It couldn't be a layout test since layout test reference images are not transparent. BUG=689349 Review-Url: https://codereview.chromium.org/2811593007 Cr-Commit-Position: refs/heads/master@{#463959} Committed: https://chromium.googlesource.com/chromium/src/+/e9ea97fc860799cbacaf65a32d5d87276b5409dd

Patch Set 1 #

Patch Set 2 : copy from surface #

Patch Set 3 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 2 1 chunk +33 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
Eric Seckler
Dmitry, PTAL :)
3 years, 8 months ago (2017-04-11 11:37:02 UTC) #2
Sami
Drive-by lgtm.
3 years, 8 months ago (2017-04-11 11:44:50 UTC) #6
dgozman
lgtm!
3 years, 8 months ago (2017-04-11 17:34:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811593007/40001
3 years, 8 months ago (2017-04-12 07:26:13 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 08:18:17 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e9ea97fc860799cbacaf65a32d5d...

Powered by Google App Engine
This is Rietveld 408576698