Issue 2811593006: Lesser direct Compiler use in SSA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2811593006: Lesser direct Compiler use in SSA (Closed)

Created:
3 years, 8 months ago by Johnni Winther

Modified:
3 years, 8 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Lesser direct Compiler use in SSA This is a step towards using data object rather than Compiler and JavaScriptBackend in codegen. This is needed to support a shift in element models between resolution and codegen. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/1973b42b00dd5c97421e99b6be8d69e6dc704954

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -22 lines)			Patch
M	pkg/compiler/lib/src/ssa/builder.dart	View	12 chunks	+14 lines, -14 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder_kernel.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/graph_builder.dart	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/ssa/kernel_string_builder.dart	View	3 chunks	+3 lines, -5 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

3 years, 8 months ago (2017-04-12 09:33:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1973b42b00dd5c97421e99b6be8d69e6dc704954 (presubmit successful).