Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: pkg/compiler/lib/src/ssa/kernel_string_builder.dart

Issue 2811593006: Lesser direct Compiler use in SSA (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/graph_builder.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/kernel_string_builder.dart
diff --git a/pkg/compiler/lib/src/ssa/kernel_string_builder.dart b/pkg/compiler/lib/src/ssa/kernel_string_builder.dart
index ddef20aa35bf7412e7eeddfacb57dd7e67d7bf77..f051ba05a62e3ba255cba1870d31dc63a1502ab8 100644
--- a/pkg/compiler/lib/src/ssa/kernel_string_builder.dart
+++ b/pkg/compiler/lib/src/ssa/kernel_string_builder.dart
@@ -4,8 +4,7 @@
import 'package:kernel/ast.dart' as ir;
-import '../compiler.dart';
-
+import '../common.dart';
import 'builder_kernel.dart';
import 'kernel_ast_adapter.dart';
import 'nodes.dart';
@@ -13,7 +12,6 @@ import 'nodes.dart';
/// Visits and concatenates the expressions in a string concatenation.
class KernelStringBuilder extends ir.Visitor {
final KernelSsaBuilder builder;
- Compiler get compiler => builder.compiler;
KernelAstAdapter get astAdapter => builder.astAdapter;
/// The string value generated so far.
@@ -23,8 +21,8 @@ class KernelStringBuilder extends ir.Visitor {
@override
void defaultNode(ir.Node node) {
- compiler.reporter
- .internalError(astAdapter.getNode(node), 'Unexpected node.');
+ throw new SpannableAssertionFailure(
+ astAdapter.getNode(node), 'Unexpected node.');
}
@override
« no previous file with comments | « pkg/compiler/lib/src/ssa/graph_builder.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698