Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2811593005: Mark 201 DCHECK SPV2 tests as failing/crashing (Closed)

Created:
3 years, 8 months ago by pdr.
Modified:
3 years, 8 months ago
Reviewers:
chrishtr, wkorman
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark 201 DCHECK SPV2 tests as failing/crashing This patch prepares SPV2 expectations for enabling DCHECKs. BUG=702805 Review-Url: https://codereview.chromium.org/2811593005 Cr-Commit-Position: refs/heads/master@{#463449} Committed: https://chromium.googlesource.com/chromium/src/+/1e503ec28387c6ed0e5da7e17560a6e7ddb1a65a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -103 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 24 chunks +204 lines, -103 lines 1 comment Download

Messages

Total messages: 10 (5 generated)
pdr.
3 years, 8 months ago (2017-04-10 21:41:04 UTC) #2
chrishtr
lgtm
3 years, 8 months ago (2017-04-10 21:45:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811593005/1
3 years, 8 months ago (2017-04-10 21:46:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1e503ec28387c6ed0e5da7e17560a6e7ddb1a65a
3 years, 8 months ago (2017-04-10 23:48:31 UTC) #8
wkorman
3 years, 8 months ago (2017-04-11 00:16:06 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/2811593005/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
(right):

https://codereview.chromium.org/2811593005/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:1412:
crbug.com/702805 virtual/threaded/transitions/opacity-transition-zindex.html [
Crash ]
FYI some of the animation/transition entries below are due to
http://crbug.com/702350#c12

Powered by Google App Engine
This is Rietveld 408576698