Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2811593002: [turbofan] Remove the obsolete PropertyAccessInfo::Generic. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove the obsolete PropertyAccessInfo::Generic. The Generic access info was introduced to handle transitioning stores that extend the properties backing store (by reusing the STORE_IC). But since crrev.com/2778133003 TurboFan handles these by just inlining the properties backing store (re)allocation, and thus this is now dead code. BUG=v8:5267 Review-Url: https://codereview.chromium.org/2811593002 Cr-Commit-Position: refs/heads/master@{#44505} Committed: https://chromium.googlesource.com/v8/v8/+/05e5256a312df851548607a502e5df47a7a0bce6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -69 lines) Patch
M src/compiler/access-info.h View 3 chunks +1 line, -4 lines 0 comments Download
M src/compiler/access-info.cc View 2 chunks +1 line, -8 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 2 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 11 chunks +14 lines, -50 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Benedikt Meurer
Hey Jaro, As discussed last week, here's the dead code removal. Please take a look. ...
3 years, 8 months ago (2017-04-10 05:27:44 UTC) #4
Jarin
lgtm
3 years, 8 months ago (2017-04-10 07:17:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811593002/1
3 years, 8 months ago (2017-04-10 07:18:10 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 07:19:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/05e5256a312df851548607a502e5df47a7a...

Powered by Google App Engine
This is Rietveld 408576698