MD Settings: Restore focus when exiting various subpages, part 2.

MD Settings: Restore focus when exiting various subpages, part 2.

Addressing subpages residing in
 - about_page
 - android_apps_page
 - privacy_page (except site settings sub-subpages).
 - device_page

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2811573004
Cr-Commit-Position: refs/heads/master@{#463800}
Committed: https://chromium.googlesource.com/chromium/src/+/81f6e86468ad7d5b28e2ab17fff1c2a85422fc0a

[dpapad, 2017-04-11 18:41:49]

Description was changed from

==========
MD Settings: Restore focus when exitnig "detailed build info" subpage.

BUG=709586
==========

to

==========
MD Settings: Restore focus when exitnig "detailed build info" subpage.

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-11 18:50:37]

Description was changed from

==========
MD Settings: Restore focus when exitnig "detailed build info" subpage.

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Restore focus when exiting various subpages, part 2.

Addressing subpages residing in
 - about_page (ChromeOS only)
 - privacy_page (except site settings sub-subpages).


BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-11 18:50:59]

Description was changed from

==========
MD Settings: Restore focus when exiting various subpages, part 2.

Addressing subpages residing in
 - about_page (ChromeOS only)
 - privacy_page (except site settings sub-subpages).


BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Restore focus when exiting various subpages, part 2.

Addressing subpages residing in
 - about_page (subpage exists on ChromeOS only)
 - privacy_page (except site settings sub-subpages).


BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-11 21:06:06]

Description was changed from

==========
MD Settings: Restore focus when exiting various subpages, part 2.

Addressing subpages residing in
 - about_page (subpage exists on ChromeOS only)
 - privacy_page (except site settings sub-subpages).


BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Restore focus when exiting various subpages, part 2.

Addressing subpages residing in
 - about_page
 - android_apps_page
 - privacy_page (except site settings sub-subpages).
 - device_page


BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-11 21:10:09]

Description was changed from

==========
MD Settings: Restore focus when exiting various subpages, part 2.

Addressing subpages residing in
 - about_page
 - android_apps_page
 - privacy_page (except site settings sub-subpages).
 - device_page


BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Restore focus when exiting various subpages, part 2.

Addressing subpages residing in
 - about_page
 - android_apps_page
 - privacy_page (except site settings sub-subpages).
 - device_page

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-11 21:10:53]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 21:12:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-04-11 21:32:25]

dpapad@chromium.org changed reviewers:
+ tommycli@chromium.org

[tommycli, 2017-04-11 21:34:18]

lgtm. I think the focusConfig_ being a property mechanism is very beautiful.

[dpapad, 2017-04-11 21:42:23]

On 2017/04/11 at 21:34:18, tommycli wrote:
> lgtm. I think the focusConfig_ being a property mechanism is very beautiful.

Indeed. It has worked well so far.
Having said that I am now starting to address the harder cases (sub-sub pages),
where the subpage trigger is not in the same Shadow DOM as the
<settings-animated-pages>, example
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_s....
So need to think of some way to still be able to focus the right element.

[tommycli, 2017-04-11 21:43:23]

On 2017/04/11 21:42:23, dpapad wrote:
> On 2017/04/11 at 21:34:18, tommycli wrote:
> > lgtm. I think the focusConfig_ being a property mechanism is very beautiful.
> 
> Indeed. It has worked well so far.
> Having said that I am now starting to address the harder cases (sub-sub
pages),
> where the subpage trigger is not in the same Shadow DOM as the
> <settings-animated-pages>, example
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_s....
> So need to think of some way to still be able to focus the right element.

Oh gee that's irritating.

[dpapad, 2017-04-11 22:03:38]

The CQ bit was unchecked by dpapad@chromium.org

[dpapad, 2017-04-11 22:03:40]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-04-11 22:04:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 22:19:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491948220116650,
"parent_rev": "9594ef36367ebb69e772f4d9f99e1f8bb6e1ca12", "commit_rev":
"81f6e86468ad7d5b28e2ab17fff1c2a85422fc0a"}

[commit-bot: I haz the power, 2017-04-11 22:19:53]

Description was changed from

==========
MD Settings: Restore focus when exiting various subpages, part 2.

Addressing subpages residing in
 - about_page
 - android_apps_page
 - privacy_page (except site settings sub-subpages).
 - device_page

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Restore focus when exiting various subpages, part 2.

Addressing subpages residing in
 - about_page
 - android_apps_page
 - privacy_page (except site settings sub-subpages).
 - device_page

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2811573004
Cr-Commit-Position: refs/heads/master@{#463800}
Committed:
https://chromium.googlesource.com/chromium/src/+/81f6e86468ad7d5b28e2ab17fff1...
==========

[commit-bot: I haz the power, 2017-04-11 22:19:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/81f6e86468ad7d5b28e2ab17fff1...