Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2811513002: gpu: Simplify the error handling during gpu memory buffer allocation. (Closed)

Created:
3 years, 8 months ago by sadrul
Modified:
3 years, 8 months ago
Reviewers:
reveman, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Simplify the error handling during gpu memory buffer allocation. Notify BrowserGpuMemoryBufferManager from GpuProcessHost the reason for failure to allocate gpu memory buffer. The gmb-manager then uses that information to decide whether it can try again. This allows simplifying the relevant code in BrowserGpuMemoryBufferManager. BUG=709332 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2811513002 Cr-Commit-Position: refs/heads/master@{#463414} Committed: https://chromium.googlesource.com/chromium/src/+/4784619fba45abbf811939fe143c1378fe003246

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : tot merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -84 lines) Patch
M content/browser/gpu/browser_gpu_memory_buffer_manager.h View 1 4 chunks +7 lines, -19 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 2 7 chunks +18 lines, -61 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (20 generated)
sadrul
3 years, 8 months ago (2017-04-09 07:45:12 UTC) #10
reveman
thanks lgtm
3 years, 8 months ago (2017-04-10 16:42:40 UTC) #13
sadrul
+piman@ for owners
3 years, 8 months ago (2017-04-10 16:43:29 UTC) #15
piman
lgtm
3 years, 8 months ago (2017-04-10 17:54:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811513002/40001
3 years, 8 months ago (2017-04-10 21:20:18 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 22:08:12 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4784619fba45abbf811939fe143c...

Powered by Google App Engine
This is Rietveld 408576698