Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2811483002:
Ensure password protection service can receive non http/s URLs (Closed)
|
Created:
3 years, 8 months ago by Charlie Harrison Modified:
3 years, 8 months ago Reviewers:
Jialiu Lin CC:
chromium-reviews, grt+watch_chromium.org, timvolodine, vakh+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnsure password protection service can receive non http/s URLs
This fixes a wrong DCHECK where code does not expect deleted history
entries to be non-http/s.
BUG=709758
Review-Url: https://codereview.chromium.org/2811483002
Cr-Commit-Position: refs/heads/master@{#463157}
Committed: https://chromium.googlesource.com/chromium/src/+/e2ed4b4539b7a50d8be892e4437897b18c181c91
Patch Set 1 #
Messages
Total messages: 24 (13 generated)
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
csharrison@chromium.org changed reviewers: + jialiul@chromium.org
jialiul: PTAL?
LGTM. Thank you csharrison for fixing my bug.
No problem :) thanks for the quick review.
The CQ bit was unchecked by csharrison@chromium.org
The CQ bit was checked by csharrison@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by csharrison@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by jialiul@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by csharrison@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491781634845160, "parent_rev":
"373b1ecb464977173aa74566bb6f672be10df687", "commit_rev":
"e2ed4b4539b7a50d8be892e4437897b18c181c91"}
Message was sent while issue was closed.
Description was changed from ========== Ensure password protection service can receive non http/s URLs This fixes a wrong DCHECK where code does not expect deleted history entries to be non-http/s. BUG=709758 ========== to ========== Ensure password protection service can receive non http/s URLs This fixes a wrong DCHECK where code does not expect deleted history entries to be non-http/s. BUG=709758 Review-Url: https://codereview.chromium.org/2811483002 Cr-Commit-Position: refs/heads/master@{#463157} Committed: https://chromium.googlesource.com/chromium/src/+/e2ed4b4539b7a50d8be892e44378... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e2ed4b4539b7a50d8be892e44378... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
