Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: third_party/WebKit/Source/platform/text/TextRun.h

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/text/TextRun.h
diff --git a/third_party/WebKit/Source/platform/text/TextRun.h b/third_party/WebKit/Source/platform/text/TextRun.h
index 9c85b86083b8b246d09d3742d680b2683e8be139..5f22042515ca3aba62765fa560a59b061d892651 100644
--- a/third_party/WebKit/Source/platform/text/TextRun.h
+++ b/third_party/WebKit/Source/platform/text/TextRun.h
@@ -144,7 +144,7 @@ class PLATFORM_EXPORT TextRun final {
}
TextRun subRun(unsigned startOffset, unsigned length) const {
- ASSERT(startOffset < m_len);
+ DCHECK_LT(startOffset, m_len);
TextRun result = *this;
@@ -162,21 +162,21 @@ class PLATFORM_EXPORT TextRun final {
}
const LChar* data8(unsigned i) const {
SECURITY_DCHECK(i < m_len);
- ASSERT(is8Bit());
+ DCHECK(is8Bit());
return &m_data.characters8[i];
}
const UChar* data16(unsigned i) const {
SECURITY_DCHECK(i < m_len);
- ASSERT(!is8Bit());
+ DCHECK(!is8Bit());
return &m_data.characters16[i];
}
const LChar* characters8() const {
- ASSERT(is8Bit());
+ DCHECK(is8Bit());
return m_data.characters8;
}
const UChar* characters16() const {
- ASSERT(!is8Bit());
+ DCHECK(!is8Bit());
return m_data.characters16;
}

Powered by Google App Engine
This is Rietveld 408576698