Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp
diff --git a/third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp b/third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp
index f6bcfbe2b35a093204dbd7f59d9f4cd407c3b760..7a535bb5103d45707b8a7483bf8f39000202e5b1 100644
--- a/third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp
+++ b/third_party/WebKit/Source/platform/text/UnicodeUtilities.cpp
@@ -151,7 +151,7 @@ bool isKanaLetter(UChar character) {
}
bool isSmallKanaLetter(UChar character) {
- ASSERT(isKanaLetter(character));
+ DCHECK(isKanaLetter(character));
switch (character) {
case 0x3041: // HIRAGANA LETTER SMALL A
@@ -209,7 +209,7 @@ bool isSmallKanaLetter(UChar character) {
}
static inline VoicedSoundMarkType composedVoicedSoundMark(UChar character) {
- ASSERT(isKanaLetter(character));
+ DCHECK(isKanaLetter(character));
switch (character) {
case 0x304C: // HIRAGANA LETTER GA
@@ -295,16 +295,16 @@ bool containsKanaLetters(const String& pattern) {
void normalizeCharactersIntoNFCForm(const UChar* characters,
unsigned length,
Vector<UChar>& buffer) {
- ASSERT(length);
+ DCHECK(length);
buffer.resize(length);
UErrorCode status = U_ZERO_ERROR;
size_t bufferSize = unorm_normalize(characters, length, UNORM_NFC, 0,
buffer.data(), length, &status);
- ASSERT(status == U_ZERO_ERROR || status == U_STRING_NOT_TERMINATED_WARNING ||
+ DCHECK(status == U_ZERO_ERROR || status == U_STRING_NOT_TERMINATED_WARNING ||
status == U_BUFFER_OVERFLOW_ERROR);
- ASSERT(bufferSize);
+ DCHECK(bufferSize);
buffer.resize(bufferSize);
@@ -314,7 +314,7 @@ void normalizeCharactersIntoNFCForm(const UChar* characters,
status = U_ZERO_ERROR;
unorm_normalize(characters, length, UNORM_NFC, 0, buffer.data(), bufferSize,
&status);
- ASSERT(status == U_STRING_NOT_TERMINATED_WARNING);
+ DCHECK_EQ(status, U_STRING_NOT_TERMINATED_WARNING);
}
// This function returns kNotFound if |first| and |second| contain different

Powered by Google App Engine
This is Rietveld 408576698