Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Unified Diff: third_party/WebKit/Source/platform/text/SegmentedString.h

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/text/SegmentedString.h
diff --git a/third_party/WebKit/Source/platform/text/SegmentedString.h b/third_party/WebKit/Source/platform/text/SegmentedString.h
index 29e56aad6a8099530a5669c0901c3213e58c59b5..f76f1ab5ddf76e92f5e5a9148cb65802ddad5580 100644
--- a/third_party/WebKit/Source/platform/text/SegmentedString.h
+++ b/third_party/WebKit/Source/platform/text/SegmentedString.h
@@ -118,12 +118,12 @@ class PLATFORM_EXPORT SegmentedSubstring {
}
UChar incrementAndGetCurrentChar8() {
- ASSERT(m_data.string8Ptr);
+ DCHECK(m_data.string8Ptr);
return *++m_data.string8Ptr;
}
UChar incrementAndGetCurrentChar16() {
- ASSERT(m_data.string16Ptr);
+ DCHECK(m_data.string16Ptr);
return *++m_data.string16Ptr;
}
@@ -133,14 +133,14 @@ class PLATFORM_EXPORT SegmentedSubstring {
}
ALWAYS_INLINE UChar getCurrentChar() {
- ASSERT(m_length);
+ DCHECK(m_length);
if (is8Bit())
return getCurrentChar8();
return getCurrentChar16();
}
ALWAYS_INLINE UChar incrementAndGetCurrentChar() {
- ASSERT(m_length);
+ DCHECK(m_length);
if (is8Bit())
return incrementAndGetCurrentChar8();
return incrementAndGetCurrentChar16();
@@ -270,12 +270,12 @@ class PLATFORM_EXPORT SegmentedString {
}
void advancePastNonNewline() {
- ASSERT(currentChar() != '\n');
+ DCHECK_NE(currentChar(), '\n');
advance();
}
void advancePastNewlineAndUpdateLineNumber() {
- ASSERT(currentChar() == '\n');
+ DCHECK_EQ(currentChar(), '\n');
if (m_currentString.length() > 1) {
int newLineFlag = m_currentString.doNotExcludeLineNumbers();
m_currentLine += newLineFlag;
@@ -336,7 +336,7 @@ class PLATFORM_EXPORT SegmentedString {
void updateSlowCaseFunctionPointers();
void decrementAndCheckLength() {
- ASSERT(m_currentString.length() > 1);
+ DCHECK_GT(m_currentString.length(), 1);
m_currentString.decrementLength();
if (m_currentString.haveOneCharacterLeft())
updateSlowCaseFunctionPointers();

Powered by Google App Engine
This is Rietveld 408576698