third_party/WebKit/Source/platform/text/LocaleWin.cpp - Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text

Unified Diff: third_party/WebKit/Source/platform/text/LocaleWin.cpp

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/LocaleWin.cpp

diff --git a/third_party/WebKit/Source/platform/text/LocaleWin.cpp b/third_party/WebKit/Source/platform/text/LocaleWin.cpp

index d2fe3d63fc289563a5489a7461005dc60583101c..26f1e1ead25529604c62b3ac96d8d99112b93ac5 100644

--- a/third_party/WebKit/Source/platform/text/LocaleWin.cpp

+++ b/third_party/WebKit/Source/platform/text/LocaleWin.cpp

@@ -207,7 +207,7 @@ static String convertWindowsDateTimeFormat(const String& format) {

if (inQuote) {

if (ch == '\'') {

inQuote = false;

- ASSERT(i);

+ DCHECK(i);

if (lastQuoteCanBeLiteral && format[i - 1] == '\'') {

literalBuffer.append('\'');

lastQuoteCanBeLiteral = false;

@@ -450,15 +450,15 @@ void LocaleWin::initializeLocaleData() {

symbols.push_back("9");

} else {

String digits = getLocaleInfoString(LOCALE_SNATIVEDIGITS);

- ASSERT(digits.length() >= 10);

+ DCHECK_GE(digits.length(), 10u);

for (unsigned i = 0; i < 10; ++i)

symbols.push_back(digits.substring(i, 1));

}

- ASSERT(symbols.size() == DecimalSeparatorIndex);

+ DCHECK(symbols.size() == DecimalSeparatorIndex);

tkent 2017/04/09 23:07:01 Use DCHECK_EQ if it doesn't cause a compile failur

Hwanseung Lee 2017/04/11 03:29:38 it was cause a compile failure.

symbols.push_back(getLocaleInfoString(LOCALE_SDECIMAL));

- ASSERT(symbols.size() == GroupSeparatorIndex);

+ DCHECK(symbols.size() == GroupSeparatorIndex);

tkent 2017/04/09 23:07:01 Use DCHECK_EQ if it doesn't cause a compile failur

Hwanseung Lee 2017/04/11 03:29:38 it was cause a compile failure.

symbols.push_back(getLocaleInfoString(LOCALE_STHOUSAND));

- ASSERT(symbols.size() == DecimalSymbolsSize);

+ DCHECK(symbols.size() == DecimalSymbolsSize);

tkent 2017/04/09 23:07:01 Use DCHECK_EQ if it doesn't cause a compile failur

Hwanseung Lee 2017/04/11 03:29:38 it was cause a compile failure.

String negativeSign = getLocaleInfoString(LOCALE_SNEGATIVESIGN);

enum NegativeFormat {