Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: third_party/WebKit/Source/platform/text/SegmentedString.cpp

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/text/SegmentedString.cpp
diff --git a/third_party/WebKit/Source/platform/text/SegmentedString.cpp b/third_party/WebKit/Source/platform/text/SegmentedString.cpp
index e7ceffa9008e3ec1da0ef09ba37b2f22ae83ef65..44a0b4eff2af3c9ab498de9998bb6f781d9cafae 100644
--- a/third_party/WebKit/Source/platform/text/SegmentedString.cpp
+++ b/third_party/WebKit/Source/platform/text/SegmentedString.cpp
@@ -57,7 +57,7 @@ void SegmentedString::clear() {
}
void SegmentedString::append(const SegmentedSubstring& s) {
- ASSERT(!m_closed);
+ DCHECK(!m_closed);
if (!s.length())
return;
@@ -73,7 +73,7 @@ void SegmentedString::append(const SegmentedSubstring& s) {
}
void SegmentedString::push(UChar c) {
- ASSERT(c);
+ DCHECK(c);
// pushIfPossible attempts to rewind the pointer in the SegmentedSubstring,
// however it will fail if the SegmentedSubstring is empty, or
@@ -88,7 +88,7 @@ void SegmentedString::push(UChar c) {
}
void SegmentedString::prepend(const SegmentedSubstring& s, PrependType type) {
- ASSERT(!s.numberOfCharactersConsumed());
+ DCHECK(!s.numberOfCharactersConsumed());
if (!s.length())
return;
@@ -113,12 +113,12 @@ void SegmentedString::prepend(const SegmentedSubstring& s, PrependType type) {
void SegmentedString::close() {
// Closing a stream twice is likely a coding mistake.
- ASSERT(!m_closed);
+ DCHECK(!m_closed);
m_closed = true;
}
void SegmentedString::append(const SegmentedString& s) {
- ASSERT(!m_closed);
+ DCHECK(!m_closed);
append(s.m_currentString);
if (s.isComposite()) {
@@ -195,7 +195,7 @@ void SegmentedString::advance16() {
}
void SegmentedString::advanceAndUpdateLineNumber8() {
- ASSERT(m_currentString.getCurrentChar() == m_currentChar);
+ DCHECK_EQ(m_currentString.getCurrentChar(), m_currentChar);
if (m_currentChar == '\n') {
++m_currentLine;
m_numberOfCharactersConsumedPriorToCurrentLine =
@@ -206,7 +206,7 @@ void SegmentedString::advanceAndUpdateLineNumber8() {
}
void SegmentedString::advanceAndUpdateLineNumber16() {
- ASSERT(m_currentString.getCurrentChar() == m_currentChar);
+ DCHECK_EQ(m_currentString.getCurrentChar(), m_currentChar);
if (m_currentChar == '\n') {
++m_currentLine;
m_numberOfCharactersConsumedPriorToCurrentLine =
@@ -260,7 +260,7 @@ void SegmentedString::advanceAndUpdateLineNumberSlowCase() {
}
void SegmentedString::advanceEmpty() {
- ASSERT(!m_currentString.length() && !isComposite());
+ DCHECK(!m_currentString.length() && !isComposite());
tkent 2017/04/09 23:07:01 Split this into two DCHECKs
Hwanseung Lee 2017/04/11 03:29:38 Done.
m_currentChar = 0;
}

Powered by Google App Engine
This is Rietveld 408576698