Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: third_party/WebKit/Source/platform/text/BidiResolverTest.cpp

Issue 2811453002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/text Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/text/BidiResolverTest.cpp
diff --git a/third_party/WebKit/Source/platform/text/BidiResolverTest.cpp b/third_party/WebKit/Source/platform/text/BidiResolverTest.cpp
index e5de401d501aa2fcc11545f5532d24c56cc73ff5..8ce536199656b4ad5fd9981981104d07a8e5f7c8 100644
--- a/third_party/WebKit/Source/platform/text/BidiResolverTest.cpp
+++ b/third_party/WebKit/Source/platform/text/BidiResolverTest.cpp
@@ -214,7 +214,7 @@ void BidiTestRunner::runTest(const std::basic_string<UChar>& input,
// Blink's UBA just makes runs, the actual ordering of the display of
// characters is handled later in our pipeline, so we fake it here:
bool reversed = run->reversed(false);
- ASSERT(run->stop() >= run->start());
+ DCHECK_GE(run->stop(), run->start());
size_t length = run->stop() - run->start();
for (size_t i = 0; i < length; i++) {
int inputIndex = reversed ? run->stop() - i - 1 : run->start() + i;

Powered by Google App Engine
This is Rietveld 408576698