Roll src/third_party/boringssl/src c8ff30cbe..bc6a76b0e

Roll src/third_party/boringssl/src c8ff30cbe..bc6a76b0e

https://boringssl.googlesource.com/boringssl/+log/c8ff30cbe716c72279a6f6a9d7d7d0d4091220fa..bc6a76b0e0ed252af1688423584f7cd9161f6dee

BUG=none

Review-Url: https://codereview.chromium.org/2811393005
Cr-Commit-Position: refs/heads/master@{#465244}
Committed: https://chromium.googlesource.com/chromium/src/+/dc615d216b891170a55a2c14bf594c33866eb654

[svaldez, 2017-04-14 20:40:39]

The CQ bit was checked by svaldez@chromium.org to run a CQ dry run

[svaldez, 2017-04-14 20:41:05]

svaldez@chromium.org changed reviewers:
+ davidben@chromium.org

[commit-bot: I haz the power, 2017-04-14 20:41:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2017-04-14 20:47:33]

lgtm

[svaldez, 2017-04-14 20:58:36]

The CQ bit was unchecked by svaldez@chromium.org

[svaldez, 2017-04-14 20:58:36]

The CQ bit was checked by svaldez@chromium.org

[svaldez, 2017-04-14 20:58:38]

The CQ bit was unchecked by svaldez@chromium.org

[svaldez, 2017-04-14 20:58:45]

The CQ bit was checked by svaldez@chromium.org

[commit-bot: I haz the power, 2017-04-14 20:58:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 21:22:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 21:22:22]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[svaldez, 2017-04-18 14:11:55]

The CQ bit was checked by svaldez@chromium.org

[commit-bot: I haz the power, 2017-04-18 14:12:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 15:28:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492524715140410, "parent_rev":
"5eed7fcf9120c17c80d8bfe31519ac793352ec70", "commit_rev":
"dc615d216b891170a55a2c14bf594c33866eb654"}

[commit-bot: I haz the power, 2017-04-18 15:29:44]

Description was changed from

==========
Roll src/third_party/boringssl/src c8ff30cbe..bc6a76b0e

https://boringssl.googlesource.com/boringssl/+log/c8ff30cbe716c72279a6f6a9d7d...

BUG=none
==========

to

==========
Roll src/third_party/boringssl/src c8ff30cbe..bc6a76b0e

https://boringssl.googlesource.com/boringssl/+log/c8ff30cbe716c72279a6f6a9d7d...

BUG=none

Review-Url: https://codereview.chromium.org/2811393005
Cr-Commit-Position: refs/heads/master@{#465244}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc615d216b891170a55a2c14bf59...
==========

[commit-bot: I haz the power, 2017-04-18 15:29:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dc615d216b891170a55a2c14bf59...

[xunjieli, 2017-04-18 16:37:41]

On 2017/04/18 15:29:46, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/dc615d216b891170a55a2c14bf59...

Seems have broken Cronet tests which run against a Netty server.
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Bui...

C  227.881s Main  Caused by: java.lang.Exception: Invalid Server SSL Protocol
(error:00000000:invalid library (0):OPENSSL_internal:invalid library (0))
C  227.881s Main  	at org.apache.tomcat.jni.SSLContext.make(Native Method)
C  227.881s Main  	at
io.netty.handler.ssl.OpenSslContext.<init>(OpenSslContext.java:186)

I tried to revert this CL but looks like this is too big to revert.
Steven, could you look into it?

[davidben, 2017-04-18 16:44:28]

On 2017/04/18 16:37:41, xunjieli wrote:
> On 2017/04/18 15:29:46, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/dc615d216b891170a55a2c14bf59...
> 
> Seems have broken Cronet tests which run against a Netty server.
>
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Bui...
> 
> C  227.881s Main  Caused by: java.lang.Exception: Invalid Server SSL Protocol
> (error:00000000:invalid library (0):OPENSSL_internal:invalid library (0))
> C  227.881s Main  	at org.apache.tomcat.jni.SSLContext.make(Native Method)
> C  227.881s Main  	at
> io.netty.handler.ssl.OpenSslContext.<init>(OpenSslContext.java:186)
> 
> I tried to revert this CL but looks like this is too big to revert.
> Steven, could you look into it?

I believe the fix is to remove the ifdef here, which is just plain wrong:
https://cs.chromium.org/chromium/src/third_party/netty-tcnative/src/c/sslcont...

https://github.com/netty/netty-tcnative/commit/c9e7cde8d5bd52e338637a08c76ac2...

Is this on the CQ anywhere? Cronet is using some amazingly low-quality and
out-of-date code as part of Netty tests here. This isn't the first time we've
had problems with it. Is there a try server we can remember to run at least?
We're going to need something more proactive available to be able to support
that code. If someone from Cronet could also take ownership of updating it to a
less ancient version, that would also be good.

[xunjieli, 2017-04-18 16:49:58]

On 2017/04/18 16:44:28, davidben wrote:
> On 2017/04/18 16:37:41, xunjieli wrote:
> > On 2017/04/18 15:29:46, commit-bot: I haz the power wrote:
> > > Committed patchset #1 (id:1) as
> > >
> >
>
https://chromium.googlesource.com/chromium/src/+/dc615d216b891170a55a2c14bf59...
> > 
> > Seems have broken Cronet tests which run against a Netty server.
> >
>
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Bui...
> > 
> > C  227.881s Main  Caused by: java.lang.Exception: Invalid Server SSL
Protocol
> > (error:00000000:invalid library (0):OPENSSL_internal:invalid library (0))
> > C  227.881s Main  	at org.apache.tomcat.jni.SSLContext.make(Native Method)
> > C  227.881s Main  	at
> > io.netty.handler.ssl.OpenSslContext.<init>(OpenSslContext.java:186)
> > 
> > I tried to revert this CL but looks like this is too big to revert.
> > Steven, could you look into it?
> 
> I believe the fix is to remove the ifdef here, which is just plain wrong:
>
https://cs.chromium.org/chromium/src/third_party/netty-tcnative/src/c/sslcont...
> 
>
https://github.com/netty/netty-tcnative/commit/c9e7cde8d5bd52e338637a08c76ac2...
> 
> Is this on the CQ anywhere?

"cronet_android_tester". You need to choose it from the trybot dropdown.

> Cronet is using some amazingly low-quality and
> out-of-date code as part of Netty tests here. This isn't the first time we've
> had problems with it. Is there a try server we can remember to run at least?
> We're going to need something more proactive available to be able to support
> that code. If someone from Cronet could also take ownership of updating it to
a
> less ancient version, that would also be good.

third_party/netty-tcnative/OWNERS

[xunjieli, 2017-04-18 16:50:41]

Description was changed from

==========
Roll src/third_party/boringssl/src c8ff30cbe..bc6a76b0e

https://boringssl.googlesource.com/boringssl/+log/c8ff30cbe716c72279a6f6a9d7d...

BUG=none

Review-Url: https://codereview.chromium.org/2811393005
Cr-Commit-Position: refs/heads/master@{#465244}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc615d216b891170a55a2c14bf59...
==========

to

==========
Roll src/third_party/boringssl/src c8ff30cbe..bc6a76b0e

https://boringssl.googlesource.com/boringssl/+log/c8ff30cbe716c72279a6f6a9d7d...

BUG=none

Review-Url: https://codereview.chromium.org/2811393005
Cr-Commit-Position: refs/heads/master@{#465244}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc615d216b891170a55a2c14bf59...
==========

[davidben, 2017-04-18 16:56:32]

On 2017/04/18 16:49:58, xunjieli wrote:
> On 2017/04/18 16:44:28, davidben wrote:
> > On 2017/04/18 16:37:41, xunjieli wrote:
> > > On 2017/04/18 15:29:46, commit-bot: I haz the power wrote:
> > > > Committed patchset #1 (id:1) as
> > > >
> > >
> >
>
https://chromium.googlesource.com/chromium/src/+/dc615d216b891170a55a2c14bf59...
> > > 
> > > Seems have broken Cronet tests which run against a Netty server.
> > >
> >
>
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Bui...
> > > 
> > > C  227.881s Main  Caused by: java.lang.Exception: Invalid Server SSL
> Protocol
> > > (error:00000000:invalid library (0):OPENSSL_internal:invalid library (0))
> > > C  227.881s Main  	at org.apache.tomcat.jni.SSLContext.make(Native Method)
> > > C  227.881s Main  	at
> > > io.netty.handler.ssl.OpenSslContext.<init>(OpenSslContext.java:186)
> > > 
> > > I tried to revert this CL but looks like this is too big to revert.
> > > Steven, could you look into it?
> > 
> > I believe the fix is to remove the ifdef here, which is just plain wrong:
> >
>
https://cs.chromium.org/chromium/src/third_party/netty-tcnative/src/c/sslcont...
> > 
> >
>
https://github.com/netty/netty-tcnative/commit/c9e7cde8d5bd52e338637a08c76ac2...
> > 
> > Is this on the CQ anywhere?
> 
> "cronet_android_tester". You need to choose it from the trybot dropdown.

Thanks! We'll try to remember to run that. Are there plans to add it to the CQ?

> > Cronet is using some amazingly low-quality and
> > out-of-date code as part of Netty tests here. This isn't the first time
we've
> > had problems with it. Is there a try server we can remember to run at least?
> > We're going to need something more proactive available to be able to support
> > that code. If someone from Cronet could also take ownership of updating it
to
> a
> > less ancient version, that would also be good.
> 
> third_party/netty-tcnative/OWNERS

+kapishnikov, netty-tcnative is causing us problems again. Steven is going to
patch it for this instance, but can you please schedule some time to update it?
It really is not supportable in its current state.

[xunjieli, 2017-04-18 16:59:45]

On 2017/04/18 16:56:32, davidben wrote:
> On 2017/04/18 16:49:58, xunjieli wrote:
> > On 2017/04/18 16:44:28, davidben wrote:
> > > On 2017/04/18 16:37:41, xunjieli wrote:
> > > > On 2017/04/18 15:29:46, commit-bot: I haz the power wrote:
> > > > > Committed patchset #1 (id:1) as
> > > > >
> > > >
> > >
> >
>
https://chromium.googlesource.com/chromium/src/+/dc615d216b891170a55a2c14bf59...
> > > > 
> > > > Seems have broken Cronet tests which run against a Netty server.
> > > >
> > >
> >
>
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Bui...
> > > > 
> > > > C  227.881s Main  Caused by: java.lang.Exception: Invalid Server SSL
> > Protocol
> > > > (error:00000000:invalid library (0):OPENSSL_internal:invalid library
(0))
> > > > C  227.881s Main  	at org.apache.tomcat.jni.SSLContext.make(Native
Method)
> > > > C  227.881s Main  	at
> > > > io.netty.handler.ssl.OpenSslContext.<init>(OpenSslContext.java:186)
> > > > 
> > > > I tried to revert this CL but looks like this is too big to revert.
> > > > Steven, could you look into it?
> > > 
> > > I believe the fix is to remove the ifdef here, which is just plain wrong:
> > >
> >
>
https://cs.chromium.org/chromium/src/third_party/netty-tcnative/src/c/sslcont...
> > > 
> > >
> >
>
https://github.com/netty/netty-tcnative/commit/c9e7cde8d5bd52e338637a08c76ac2...
> > > 
> > > Is this on the CQ anywhere?
> > 
> > "cronet_android_tester". You need to choose it from the trybot dropdown.
> 
> Thanks! We'll try to remember to run that. Are there plans to add it to the
CQ?
> 

The cronet bot that is on CQ is a compile-only bot. Our test bot is not on CQ.
There is no plan yet. Things might have changed since we last talked about
getting Cronet bot on CQ. Let me start a thread.

[davidben, 2017-04-18 17:04:02]

On 2017/04/18 16:59:45, xunjieli wrote:
> On 2017/04/18 16:56:32, davidben wrote:
> > On 2017/04/18 16:49:58, xunjieli wrote:
> > > On 2017/04/18 16:44:28, davidben wrote:
> > > > On 2017/04/18 16:37:41, xunjieli wrote:
> > > > > On 2017/04/18 15:29:46, commit-bot: I haz the power wrote:
> > > > > > Committed patchset #1 (id:1) as
> > > > > >
> > > > >
> > > >
> > >
> >
>
https://chromium.googlesource.com/chromium/src/+/dc615d216b891170a55a2c14bf59...
> > > > > 
> > > > > Seems have broken Cronet tests which run against a Netty server.
> > > > >
> > > >
> > >
> >
>
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Bui...
> > > > > 
> > > > > C  227.881s Main  Caused by: java.lang.Exception: Invalid Server SSL
> > > Protocol
> > > > > (error:00000000:invalid library (0):OPENSSL_internal:invalid library
> (0))
> > > > > C  227.881s Main  	at org.apache.tomcat.jni.SSLContext.make(Native
> Method)
> > > > > C  227.881s Main  	at
> > > > > io.netty.handler.ssl.OpenSslContext.<init>(OpenSslContext.java:186)
> > > > > 
> > > > > I tried to revert this CL but looks like this is too big to revert.
> > > > > Steven, could you look into it?
> > > > 
> > > > I believe the fix is to remove the ifdef here, which is just plain
wrong:
> > > >
> > >
> >
>
https://cs.chromium.org/chromium/src/third_party/netty-tcnative/src/c/sslcont...
> > > > 
> > > >
> > >
> >
>
https://github.com/netty/netty-tcnative/commit/c9e7cde8d5bd52e338637a08c76ac2...
> > > > 
> > > > Is this on the CQ anywhere?
> > > 
> > > "cronet_android_tester". You need to choose it from the trybot dropdown.
> > 
> > Thanks! We'll try to remember to run that. Are there plans to add it to the
> CQ?
> > 
> 
> The cronet bot that is on CQ is a compile-only bot. Our test bot is not on CQ.
> There is no plan yet. Things might have changed since we last talked about
> getting Cronet bot on CQ. Let me start a thread.

That would be useful, thanks! Otherwise this is going to continue happening
since the Netty code is otherwise untested and very fragile due to its low
quality and lack of maintenance.

[xunjieli, 2017-04-18 18:24:41]

On 2017/04/18 17:04:02, davidben wrote:
> On 2017/04/18 16:59:45, xunjieli wrote:
> > On 2017/04/18 16:56:32, davidben wrote:
> > > On 2017/04/18 16:49:58, xunjieli wrote:
> > > > On 2017/04/18 16:44:28, davidben wrote:
> > > > > On 2017/04/18 16:37:41, xunjieli wrote:
> > > > > > On 2017/04/18 15:29:46, commit-bot: I haz the power wrote:
> > > > > > > Committed patchset #1 (id:1) as
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
https://chromium.googlesource.com/chromium/src/+/dc615d216b891170a55a2c14bf59...
> > > > > > 
> > > > > > Seems have broken Cronet tests which run against a Netty server.
> > > > > >
> > > > >
> > > >
> > >
> >
>
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Bui...
> > > > > > 
> > > > > > C  227.881s Main  Caused by: java.lang.Exception: Invalid Server SSL
> > > > Protocol
> > > > > > (error:00000000:invalid library (0):OPENSSL_internal:invalid library
> > (0))
> > > > > > C  227.881s Main  	at org.apache.tomcat.jni.SSLContext.make(Native
> > Method)
> > > > > > C  227.881s Main  	at
> > > > > > io.netty.handler.ssl.OpenSslContext.<init>(OpenSslContext.java:186)
> > > > > > 
> > > > > > I tried to revert this CL but looks like this is too big to revert.
> > > > > > Steven, could you look into it?
> > > > > 
> > > > > I believe the fix is to remove the ifdef here, which is just plain
> wrong:
> > > > >
> > > >
> > >
> >
>
https://cs.chromium.org/chromium/src/third_party/netty-tcnative/src/c/sslcont...
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://github.com/netty/netty-tcnative/commit/c9e7cde8d5bd52e338637a08c76ac2...
> > > > > 
> > > > > Is this on the CQ anywhere?
> > > > 
> > > > "cronet_android_tester". You need to choose it from the trybot dropdown.
> > > 
> > > Thanks! We'll try to remember to run that. Are there plans to add it to
the
> > CQ?
> > > 
> > 
> > The cronet bot that is on CQ is a compile-only bot. Our test bot is not on
CQ.
> > There is no plan yet. Things might have changed since we last talked about
> > getting Cronet bot on CQ. Let me start a thread.
> 
> That would be useful, thanks! Otherwise this is going to continue happening
> since the Netty code is otherwise untested and very fragile due to its low
> quality and lack of maintenance.

I filed https://bugs.chromium.org/p/chromium/issues/detail?id=712733